-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta API updates #23821
Jakarta API updates #23821
Conversation
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
LGTM but there seem to be 2 checkstyle errors in the java code changes: |
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Yes, thanks! I've just fixed them ad the tests are running again. |
try { | ||
return transformer.transform(loader, className, classBeingRedefined, protectionDomain, classfileBuffer); | ||
} catch (TransformerException e) { | ||
throw (IllegalClassFormatException) (new IllegalClassFormatException().initCause(e)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ugly :D
Various APIs updated
Signed-off-by: Arjan Tijms arjan.tijms@gmail.com