Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta API updates #23821

Merged
merged 12 commits into from
Feb 21, 2022
Merged

Jakarta API updates #23821

merged 12 commits into from
Feb 21, 2022

Conversation

arjantijms
Copy link
Contributor

Various APIs updated

Signed-off-by: Arjan Tijms arjan.tijms@gmail.com

Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms arjantijms added component upgrade A component dependency has been upgraded ee10-component Jakarta EE 10 component labels Feb 21, 2022
@arjantijms arjantijms added this to the 7.0.0 milestone Feb 21, 2022
@arjantijms arjantijms self-assigned this Feb 21, 2022
@hs536
Copy link
Contributor

hs536 commented Feb 21, 2022

LGTM but there seem to be 2 checkstyle errors in the java code changes:
https://ci.eclipse.org/glassfish/job/glassfish_build-and-test-using-jenkinsfile/job/PR-23821/1/execution/node/170/log/

Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms
Copy link
Contributor Author

LGTM but there seem to be 2 checkstyle errors in the java code changes:

Yes, thanks! I've just fixed them ad the tests are running again.

try {
return transformer.transform(loader, className, classBeingRedefined, protectionDomain, classfileBuffer);
} catch (TransformerException e) {
throw (IllegalClassFormatException) (new IllegalClassFormatException().initCause(e));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ugly :D

@arjantijms arjantijms merged commit b3c477f into eclipse-ee4j:master Feb 21, 2022
@arjantijms arjantijms deleted the jakartaupdate branch February 23, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component upgrade A component dependency has been upgraded ee10-component Jakarta EE 10 component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants