Hello.war app for the Quick start guide #24889

samsonsouley · 2024-04-03T07:54:27Z

Create a new module for the hello project with jakarta following the same structure of the old hello project Add the module to the project

Change hello.war file download source

OndroMih · 2024-05-04T22:20:07Z

Hello, @samsonsouley , can you sign the Eclipse Contributor Agreement according to these instructions?

Log into the Eclipse projects forge (you will need to create an account with the Eclipse Foundation if you have not already done so); click on "Eclipse Contributor Agreement"; and Complete the form. Be sure to use the same email address when you register for the account that you intend to use on Git commit records.

samsonsouley · 2024-05-05T03:06:20Z

Hello, @samsonsouley , can you sign the Eclipse Contributor Agreement according to these instructions?

Log into the Eclipse projects forge (you will need to create an account with the Eclipse Foundation if you have not already done so); click on "Eclipse Contributor Agreement"; and Complete the form. Be sure to use the same email address when you register for the account that you intend to use on Git commit records.

Hi Ondro,
Thanks it is done

OndroMih · 2024-05-05T09:06:06Z

Great, taht was really quick, @samsonsouley !

Now we need to fix one other formal thing - we need copyright headers in each file. So, please, into each new file, add the following text at the top of the file:

/*
 * Copyright (c) 2024 Contributors to the Eclipse Foundation
 *
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License v. 2.0, which is available at
 * http://www.eclipse.org/legal/epl-2.0.
 *
 * This Source Code may also be made available under the following Secondary
 * Licenses when the conditions for such availability set forth in the
 * Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
 * version 2 with the GNU Classpath Exception, which is available at
 * https://www.gnu.org/software/classpath/license.html.
 *
 * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
 */

It's a comment, so in XHTML and XML files, you'll need to replace /* and */ with XML comments= marks . And in JSP it will be <%-- and --%>

If you only updated a file, just check that the existing header contains a line with Copyright (c) Contributors to the Eclipse Foundation - and check that the line contains year 2024.

samsonsouley · 2024-05-06T06:15:39Z

Great, taht was really quick, @samsonsouley !

Now we need to fix one other formal thing - we need copyright headers in each file. So, please, into each new file, add the following text at the top of the file:
/*
 * Copyright (c) 2024 Contributors to the Eclipse Foundation
 *
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License v. 2.0, which is available at
 * http://www.eclipse.org/legal/epl-2.0.
 *
 * This Source Code may also be made available under the following Secondary
 * Licenses when the conditions for such availability set forth in the
 * Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
 * version 2 with the GNU Classpath Exception, which is available at
 * https://www.gnu.org/software/classpath/license.html.
 *
 * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
 */
It's a comment, so in XHTML and XML files, you'll need to replace /* and */ with XML comments= marks . And in JSP it will be <%-- and --%>

If you only updated a file, just check that the existing header contains a line with Copyright (c) Contributors to the Eclipse Foundation - and check that the line contains year 2024.

It is done

OndroMih · 2024-05-07T12:40:10Z

docs/EclipseGlassFishHelloSample/pom.xml

+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-dependency-plugin</artifactId>
+                <version>2.6</version>
+                <executions>
+                    <execution>
+                        <phase>validate</phase>
+                        <goals>
+                            <goal>copy</goal>
+                        </goals>
+                        <configuration>
+                            <outputDirectory>${endorsed.dir}</outputDirectory>
+                            <silent>true</silent>
+                            <artifactItems>
+                                <artifactItem>
+                                    <groupId>jakarta.platform</groupId>
+                                    <artifactId>jakarta.jakartaee-api</artifactId>
+                                    <version>${jakartaee}</version>
+                                    <type>jar</type>
+                                </artifactItem>
+                            </artifactItems>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>


This whole section is completely useless, Java doesn't support endorsed libraries anymore and all works out of the box even without this. I think this was generated by your IDE. Please remove it.

OndroMih · 2024-05-07T12:45:22Z

docs/pom.xml

@@ -61,5 +61,6 @@
        <module>troubleshooting-guide</module>
        <module>upgrade-guide</module>
        <module>distribution</module>
+        <module>EclipseGlassFishHelloSample</module>


Please rename the module so that it's similar to names of other modules. For example, this would fit more: eclipse-glassfish-hello-sample-app, or simply sample-app

I took sample-app

OndroMih · 2024-05-07T12:47:40Z

Good job, @samsonsouley !

I left a few more comments to improve this, but when those are addressed, it's all good to go and you can turn this Draft into a normal pull request.

OndroMih · 2024-05-07T18:06:30Z

All looks good now, @samsonsouley .

You can remove the draft status now, so that committers can approve and merge this

docs/sample-app/pom.xml

OndroMih · 2024-05-08T07:09:10Z

docs/sample-app/pom.xml

+    <properties>
+        <maven.compiler.release>17</maven.compiler.release>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <failOnMissingWebXml>false</failOnMissingWebXml>


This line can also be removed.

OndroMih · 2024-05-08T07:18:23Z

docs/sample-app/pom.xml

+        <dependency>
+            <groupId>org.glassfish.web</groupId>
+            <artifactId>jakarta.servlet.jsp.jstl</artifactId>
+            <version>3.0.1</version>
+        </dependency>


This can be removed, it's not used. JSP is already provided by the jakarta.jakartaee-api dependency

Well noted. It is done

docs/publish/pom.xml

docs/sample-app/src/main/webapp/WEB-INF/glassfish-web.xml

arjantijms · 2024-05-25T12:32:11Z

Thanks! :)

first comit

00e2249

Create a new module for the hello project with jakarta following the same structure of the old hello project Add the module to the project

samsonsouley changed the title ~~first commit~~ Hello.war app for the Quick start guide Apr 3, 2024

samsonsouley marked this pull request as draft April 3, 2024 15:07

samsonsouley added 2 commits April 4, 2024 00:41

Move hello.war to the downloads quickstart

4f62746

Change hello.war file download source

020ef18

Change hello.war file download source

samsonsouley closed this May 5, 2024

samsonsouley reopened this May 5, 2024

Adding copyright headers in each file

d605b32

OndroMih reviewed May 7, 2024

View reviewed changes

Change app name and modify the pom.xml

ab5c532

pzygielo reviewed May 7, 2024

View reviewed changes

docs/sample-app/pom.xml Outdated Show resolved Hide resolved

docs/sample-app/pom.xml Outdated Show resolved Hide resolved

docs/sample-app/pom.xml Outdated Show resolved Hide resolved

docs/sample-app/pom.xml Outdated Show resolved Hide resolved

Remove useless and duplicated configuration in pom.xml

d1800d5

OndroMih reviewed May 8, 2024

View reviewed changes

pzygielo reviewed May 8, 2024

View reviewed changes

docs/publish/pom.xml Outdated Show resolved Hide resolved

pzygielo reviewed May 8, 2024

View reviewed changes

docs/sample-app/src/main/webapp/WEB-INF/glassfish-web.xml Outdated Show resolved Hide resolved

Remove oracle copyright in glassfish XML

1968a90

samsonsouley marked this pull request as ready for review May 8, 2024 15:50

samsonsouley requested review from OndroMih and pzygielo May 8, 2024 15:54

Update pom.xml in publish and sample project

c245f6d

OndroMih approved these changes May 8, 2024

View reviewed changes

arjantijms approved these changes May 25, 2024

View reviewed changes

arjantijms merged commit fffe06e into eclipse-ee4j:master May 25, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hello.war app for the Quick start guide #24889

Hello.war app for the Quick start guide #24889

samsonsouley commented Apr 3, 2024 •

edited

OndroMih commented May 4, 2024

samsonsouley commented May 5, 2024 •

edited

OndroMih commented May 5, 2024

samsonsouley commented May 6, 2024

OndroMih May 7, 2024 •

edited

samsonsouley May 7, 2024

OndroMih May 7, 2024

samsonsouley May 7, 2024

OndroMih commented May 7, 2024

OndroMih commented May 7, 2024

OndroMih May 8, 2024

samsonsouley May 8, 2024

OndroMih May 8, 2024

samsonsouley May 8, 2024

arjantijms commented May 25, 2024

Hello.war app for the Quick start guide #24889

Hello.war app for the Quick start guide #24889

Conversation

samsonsouley commented Apr 3, 2024 • edited

OndroMih commented May 4, 2024

samsonsouley commented May 5, 2024 • edited

OndroMih commented May 5, 2024

samsonsouley commented May 6, 2024

OndroMih May 7, 2024 • edited

Choose a reason for hiding this comment

samsonsouley May 7, 2024

Choose a reason for hiding this comment

OndroMih May 7, 2024

Choose a reason for hiding this comment

samsonsouley May 7, 2024

Choose a reason for hiding this comment

OndroMih commented May 7, 2024

OndroMih commented May 7, 2024

OndroMih May 8, 2024

Choose a reason for hiding this comment

samsonsouley May 8, 2024

Choose a reason for hiding this comment

OndroMih May 8, 2024

Choose a reason for hiding this comment

samsonsouley May 8, 2024

Choose a reason for hiding this comment

arjantijms commented May 25, 2024

samsonsouley commented Apr 3, 2024 •

edited

samsonsouley commented May 5, 2024 •

edited

OndroMih May 7, 2024 •

edited