Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert optimization removal #1352

Merged
merged 4 commits into from
Nov 29, 2019

Conversation

danielkec
Copy link
Contributor

  • Keep optimization for Java versions older then 9 with multi-release jar
  • Add noOptimization flag for possible compatibility issues

javaee/jaxb-v2#1157

Signed-off-by: Daniel Kec daniel.kec@oracle.com

@danielkec danielkec changed the title Revert optimization removal javaee/jaxb-v2#1157 Revert optimization removal Oct 3, 2019
jaxb-ri/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pom.xml contains too many unneeded parts, rebase and clean it up, please. Thanks!

Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License in all files must be BSD

@lukasj
Copy link
Member

lukasj commented Nov 28, 2019

once you rebase this on master, travis will do the copyright check for you. It only won't tell you, which files are wrong...

  * Keep optimization for Java versions older then 9 with multi-release jar
  * Add noOptimization flag for possible compatibility issues

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Copy link
Contributor Author

once you rebase this on master, travis will do the copyright check for you. It only won't tell you, which files are wrong...

Thats a little cumbersome, I don't really get the default quiet mode. eclipse-ee4j/glassfish-copyright-plugin#8

Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 263e92e into eclipse-ee4j:master Nov 29, 2019
jimma added a commit to jimma/jaxb-ri that referenced this pull request Apr 9, 2021
lukasj pushed a commit that referenced this pull request Apr 26, 2021
* Revert "Revert optimization removal (#1352)"

This reverts commit 263e92e.
lukasj pushed a commit to lukasj/jaxb-ri that referenced this pull request Apr 26, 2021
…j#1533)

* Revert "Revert optimization removal (eclipse-ee4j#1352)"

This reverts commit 263e92e.

(cherry picked from commit a5cf4bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants