-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCK Migration: Move pending jaxrs/ee/rs/core,client,ext tests from jakartaee-tck #1029
TCK Migration: Move pending jaxrs/ee/rs/core,client,ext tests from jakartaee-tck #1029
Conversation
… in jakartaee-tck - Removed the build.xml files - Moved web.xml.template to corresponding resources folder
- rename packages - add missing classes/jar dependencies - assertFault change to assertTrue - deployment code, test run log
- add @test annotation - change assertTrue arguments to append as string - add classes or packages for archive deployable - JAXRSProvidersClientIT not to inherit core.application.JAXRSClientIT , duplicate test methods
f51c51b
to
3ff747b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Same comment as before, we should fix checkstyle rules when migration is completed. I will volunteer for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the BV dependency, it looks good. Given the BV annotations are migrated from the original Jakarta EE TCK repo, removing the annotations makes sense to be done in an extra PR.
Merging in the interest of moving forward with the rest of the migration. |
This is to migrate the pending tests from jaxrs/ee/rs/core,client,ext folders in jakartaee-tck
To test the changes :
export JAVA_HOME=<JDK11_HOME>
export M2_HOME=<MAVEN_HOME>
export PATH=$M2_HOME/bin:$JAVA_HOME/bin:$PATH
jaxrs-tck/
mvn clean install
jersey-tck/
run all tests : mvn clean verify -Parq-glassfish-managed
The tests migrated in this PR includes tests from below folders :
4 failures (tracked at #1020 ) :
jaxrs-tck/src/main/java/jakarta/ws/rs/tck/ee/rs/client/syncinvoker/JAXRSClientIT.traceWithResponseClassThrowsNoWebApplicationExceptionTest
jaxrs-tck/src/main/java/jakarta/ws/rs/tck/ee/rs/client/syncinvoker/JAXRSClientIT.traceWithGenericTypeResponseThrowsNoWebApplicationExceptionTest
jaxrs-tck/src/main/java/jakarta/ws/rs/tck/ee/rs/core/securitycontext/basic/JAXRSBasicClientIT.jbasicAuthorizationAdminTest
jaxrs-tck/src/main/java/jakarta/ws/rs/tck/ee/rs/core/securitycontext/basic/JAXRSBasicClientIT.basicAuthorizationStandardUserTest