Update Netty proxy settings #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to pass headers to the proxy Allow to set proxy using the JDK -Dhttp.proxyHost setting Signed-off-by: jansupol <jan.supol@oracle.com>
senivam
approved these changes
Jun 2, 2022
jbescos
reviewed
Jun 6, 2022
...ctors/netty-connector/src/main/java/org/glassfish/jersey/netty/connector/NettyConnector.java
Outdated
Show resolved
Hide resolved
jbescos
reviewed
Jun 6, 2022
| InetSocketAddress proxyAddr = (InetSocketAddress) proxyAddress; | ||
| if (proxyAddr.isUnresolved() | ||
| && proxyAddr.getHostName() != null | ||
| && proxyAddr.getHostName().startsWith("http://")) { |
There was a problem hiding this comment.
Is it possible that starts by https?
There was a problem hiding this comment.
No, JDK does not support HTTPS proxy
jbescos
approved these changes
Jun 6, 2022
Signed-off-by: jansupol <jan.supol@oracle.com>
jbescos
approved these changes
Jun 9, 2022
This was referenced Jun 14, 2022
Closed
This was referenced Dec 7, 2022
Closed
1 task
This was referenced Jan 6, 2023
Merged
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 1, 2023
This was referenced Jun 4, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
This was referenced Aug 28, 2023
This was referenced Jan 16, 2024
1 task
1 task
This was referenced Apr 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to pass headers to the proxy
Allow to set proxy using the JDK -Dhttp.proxyHost setting
Signed-off-by: jansupol jan.supol@oracle.com