Propagate Future.cancel() to connectors #5542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jansupol <jan.supol@oracle.com>
senivam
approved these changes
Feb 23, 2024
jbescos
reviewed
Mar 7, 2024
| @@ -157,6 +158,10 @@ protected void notifyResponse() { | |||
|
|
|||
| @Override | |||
| public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) { | |||
| if (jerseyRequest.isCancelled()) { | |||
There was a problem hiding this comment.
Netty javadoc does not provide much details about how often is this method invoked:
https://netty.io/4.0/api/io/netty/channel/SimpleChannelInboundHandler.html
Keep in mind that if this method is invoked once a response is completed, the future will be cancelled, but you will have to wait for the whole time till the response comes, which does not make much sense because the idea of cancelling is to stop execution immediately.
jbescos
approved these changes
Mar 7, 2024
1 task
1 task
1 task
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.