Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectMapper.findModules throws Error #5608

Merged
merged 1 commit into from Apr 16, 2024
Merged

ObjectMapper.findModules throws Error #5608

merged 1 commit into from Apr 16, 2024

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Apr 15, 2024 •
edited

We need to catch Throwable because it will throw java.util.ServiceConfigurationError

Related to #5604

@jbescos
ObjectMapper.findModules throws Error
0ccd98b 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
jansupol
jansupol approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@senivam senivam merged commit ec36394 into eclipse-ee4j:2.x Apr 16, 2024
7 checks passed
@senivam senivam added this to the 2.43 milestone Apr 16, 2024
This was referenced May 3, 2024
Merged
Merged
Open
Open
Closed
Merged
Open
This was referenced May 7, 2024
Open
Open
@renovate renovate bot mentioned this pull request May 7, 2024
Open
1 task
@solrbot solrbot mentioned this pull request May 7, 2024
Open
1 task
This was referenced May 24, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansupol jansupol jansupol approved these changes

@senivam senivam senivam approved these changes

Assignees

@jbescos jbescos

Labels
None yet
Projects
None yet
Milestone
2.43
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbescos @jansupol @senivam