FIX EmptyStringToNullELResolver NPE (issue 5226) #5228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pizzi80
commented
Apr 12, 2023
pizzi80
commented
- FIX EmptyStringToNullELResolver NPE #5226
Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
BalusC
reviewed
May 13, 2023
| @@ -32,7 +34,7 @@ public Class<?> getCommonPropertyType(ELContext context, Object base) { | |||
| @Override | |||
| @SuppressWarnings("unchecked") | |||
| public <T> T convertToType(ELContext context, Object value, Class<T> targetType) { | |||
| if (value == null && targetType == String.class) { | |||
| if ( value == null && targetType == String.class && EVALUATION_CONTEXT_CLASS_SIMPLE_NAME.equals(context.getClass().getSimpleName()) ) { | |||
There was a problem hiding this comment.
This is really a hack not a fix. This is prone to fail when a different EL implementation is used which doesn't use EvaluationContext as class name in this specific situation.
I'll have to look closer at this specific issue.
There was a problem hiding this comment.
Yes I know 😃 😃
but at the moment I had to fix my fork, and it works at least on Tomcat ...
I'm not able to fix it on a long term perspective 🥲
There was a problem hiding this comment.
This hack goes wrong on #{bean.setValue(null)}. It will unexpectedly set empty string there which will bring us back to zero wrt "EmptyStringToNullELResolver".
|
Declined for reason as explained in #5226 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.