Revert "Remove deprecated bindings field" #5406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d3aed24.
volosied
force-pushed
the
Revert-UIComponent.bindings-removal-from-4.1
branch
from
5e1ef03
to
c6905c9
Compare
BalusC
approved these changes
Feb 23, 2024
This was referenced Feb 23, 2024
pnicolucci
approved these changes
Feb 23, 2024
BalusC
added a commit
to jakartaee/faces
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d3aed24.
Spoke to Emily Jiang and we cannot remove this field from 4.1 as it's a minor release. If we do, it would need to be a 5.0 release and that's too much work at this point.
Linking to jakartaee/faces#1725