Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve generated default values for attributes of generic type #29

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Improve generated default values for attributes of generic type #29

merged 1 commit into from
Feb 3, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Feb 3, 2024

#25

@merks merks mentioned this pull request Feb 3, 2024
Closed
@merks
Copy link
Contributor Author

merks commented Feb 3, 2024

@claesrosell

Your comprehensive sample was super helpful not just as a test case to also to understand how this actually works well in reality. I copied small parts of the sample model into the defaults.ecore test case. Your karma points from your help with BIRT also help motivate me. 👍

@merks merks merged commit cd6a7e2 into eclipse-emf:master Feb 3, 2024
2 checks passed
@merks merks deleted the issue-25 branch February 3, 2024 10:10
@claesrosell
Copy link
Contributor

Thank you very much for this Ed, it is much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merks @claesrosell