Makefiles and installers corrected to conform to UUID4 standard #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Davide-DD for this contribution, in order to merge that, you need to sign the Eclipse contribution agreement, so register an account into the Eclipse Foundation https://www.eclipse.org/ , and after that from your profile sign the contribution agreement. After that you can just ammend your commit adding a signature And then we can merge your contribution |
Davide-DD
force-pushed
the
master
branch
3 times, most recently
from
10ed56b
to
c579b04
Compare
|
Yay, I finally made it! Sourcetree gave me a hard time just amending the signature to the previous pushed commit, and when I finally made it I discovered I was also missing the sign-off option to pass the Eclipse check! Sorry for the notifications/emails I may have generated. |
…m the machine-id to a valid UUID prior to save it in the plugins' configuration files Signed-off-by: Davide Di Donato <davidedidonato94@gmail.com>
|
No worries @Davide-DD |
gabrik
pushed a commit
that referenced
this pull request
Nov 26, 2020
…m the machine-id to a valid UUID prior to save it in the plugins' configuration files (#126) Signed-off-by: Davide Di Donato <davidedidonato94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this issue, I'm uploading some corrections to various makefiles and installers in order to transform the machine-id to a valid UUID string prior to store it in plugins' configuration files. This aligns the node ID stored in YAKS and the node ID saved in the configuration files, thus leading to have fog05 working right after the end of the installation without having to modify the node ID for each plugin configuration file.