-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable continuous integration with Travis CI #175
Conversation
57a3c34
to
a8c5503
Compare
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
a8c5503
to
81195ab
Compare
Hi @gabrielepmattia, I guess I have to merge it to see if it actually builds right? |
Hi @gabrik, there's no need to merge for seeing if it is building correctly since the build is triggered on my branch https://github.com/gabrielepmattia/fog05/tree/add-ci-script (that is even with master) and the current status can be seen here https://travis-ci.org/gabrielepmattia/fog05 I would wait to merge until we get a successful build, then I would create a tag with the version (perhaps a beta version, like 0.0.1b), in this way we can create and ship an installable .deb for Debian 10. Now I'm trying to switch to dune 1.11.4 |
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
I was looking at the logs, and It cannot find the build.sh even if it is here. |
Yes, because we didn't merged the branches, follow the logs here https://travis-ci.org/gabrielepmattia/fog05 |
We still get the same error https://travis-ci.org/gabrielepmattia/fog05/jobs/645485319#L1654 (this link should open you the log line with the error) do you mind if we switch to the install command |
Hi see, actually, for some reason I can see that when installing |
I have fixed the dependency repository, just restarted the build to check if it works |
So we need to git checkout to master apero-core? |
Nope, same tag, I have removed the old tag and created a new one with the fix. |
Perfect |
It seems that apero-core depends on ocaml < 3.07 https://travis-ci.org/gabrielepmattia/fog05/builds/645485318#L1534 |
My bad, I have done a mistake in the opam file. |
Okay, but see this issue before that eclipse-archived/api-ocaml#5 |
Can you merge your branch with https://github.com/eclipse-fog05/api-ocaml since this repo is bound to it |
Done! I was waiting for the build to work before merging. |
Seems that "atdgen" library is missing https://travis-ci.org/gabrielepmattia/fog05/jobs/645850828#L1892 |
I see I have no right to touch that repository, I suggest that for You can just add those to https://github.com/gabrielepmattia/fog05/blob/add-ci-script/.travis.yml#L18 it would become
Also as you are building in a container with the sandboxing disabled, you can avoid to install |
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
I see this: https://travis-ci.org/gabrielepmattia/fog05/builds/646060107#L2531 |
Yes, but I see that there is another dependency when installing |
That's not an issue, the I have also some question on the build of the debian packages, but I think we can discuss about it later once the build is working. |
I'm running the same CI build on a local machine to verify why inside the container it does not find opam. |
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Done, I fixed it. The dollar sign gets interpreted outside the container |
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
@gabrielepmattia I tested on a local docker, following as possible the travis CI
I guess it is worth a try |
I see it passing! Congrats @gabrielepmattia |
Perfect, it successfully builds. Can we merge this PR or do we also want to create a deb package at the end of the building phase? |
I can merge it. Ideally we should have something the ones hand-crafted in this repo: https://github.com/atolab/fog05_debs In this case, I guess that the agent+yaks+linux_plugin one can be done in this repo, while the other ones should be built by the CI of the other repositories. This means that I will update the other repositories to have a CI that follows the one of this repo. @gabrielepmattia please fell free to joint the gitter channel https://gitter.im/atolab/fog05 so we can discuss about this ;) |
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Perfect! Congrats even to you! Before merging I would make other edits:
For debs I would open another PR, and in this repo I would build only the agent since other components like yaks and linux_plugin have different repository and they can be updated independently from the fog05 agent, I guess After these changes and this merge you can create a tag with the latest version of the agent, so we have a checkpoint |
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
@gabrielepmattia please ping me when I can merge this |
Done, I think we are ready to merge |
@gabrielepmattia I have just created a pre-release tag |
* Add travis ci script and build.sh Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Switched to dune 1.11.4 Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Fixed typo in travis script * Updated sdk-ocaml git submodule dependency Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Updated api-ocaml git submodule * Added other opam deps in travis and removed bubblewrap Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Enable opam env after install in ci script Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Fixed opam env eval in ci script Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Load opam in bashrc in ci script Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Reload opam environment when building Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Temporary reinstall dune in ci script Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Trying to fix building with opamenv in ci Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Removed useless line in ci script Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Removed useless line and improved build line Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Moved installing other opam dependencies in build.sh Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Updated BUILD.md documentation Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com> * Typo in BUILD.md documentation Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
This PR is for enabling Travis CI to auto-build Fog05. CI will allow understanding if the build process succeeds in a clean environment. This contribution must consist of:
build.sh
file for automating the build (copying the instructions from BUILD.md).travis.yml
file for installing dependenciesPlease do not merge this PR until a successful build is obtained. Build log can be seen here.
Latest build of the merging branch: