#180: Add additional default types and improve arguments handling #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use some known arguments in the workflow example Fixes eclipse-glsp/glsp#180 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
tortmayr
requested changes
Apr 20, 2021
plugins/org.eclipse.glsp.graph/src/org/eclipse/glsp/graph/builder/GArgumentableBuilder.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,83 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2020 EclipseSource and others. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2020 EclipseSource and others. | |
| * Copyright (c) 2021 EclipseSource and others. |
There was a problem hiding this comment.
Good catch!
plugins/org.eclipse.glsp.graph/src/org/eclipse/glsp/graph/builder/GArgumentableBuilder.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.graph/src/org/eclipse/glsp/graph/builder/GArgumentableBuilder.java
Outdated
Show resolved
Hide resolved
plugins/org.eclipse.glsp.graph/src/org/eclipse/glsp/graph/builder/GArgumentableBuilder.java
Outdated
Show resolved
Hide resolved
|
|
||
| import org.eclipse.emf.common.util.EMap; | ||
|
|
||
| public final class GArguments extends LinkedHashMap<String, Object> { |
There was a problem hiding this comment.
In contrast to the GLayoutOptions the arguments map can hold arbitary key-value pairs so explicit subclassing and limiting the values you can put into the map doesn't make sense Imo.
I think this rather should be a GArgumentsUtil instead of Map subclass (similar to the util class for ClientOptions)
There was a problem hiding this comment.
I'm not sure I fully agree since the GArguments map can also hold arbitrary key-value pairs but It's better to be consistent ;-) I changed the structure to a utility class similar to ClientOptions.
tortmayr
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-glsp/glsp#180
Signed-off-by: Martin Fleck mfleck@eclipsesource.com