-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#738: Add route data to ComputedBoundsAction #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Martin. Code seems to work fine.
I have tested it by changing the routerKind of the workflow example edge creation handlers to "manhattan".
I have a few inline suggestions and one more general question:
I personally find it a bit odd that an action called "ComputedBoundsAction" also contains the routing points. Also by directly adapting the "ComputedBoundsAction" which we might introduce an inconsistency/incompatibility with the original ComputedBoundsAction from sprotty.
Maybe it would be better to use a dedicated ComputedRoutingPointsOperation
and wrap it together with the ComputedBoundsOperation
in a "CompoundOperation`?
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/utils/LayoutUtil.java
Outdated
Show resolved
Hide resolved
...clipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/ComputedBoundsAction.java
Show resolved
Hide resolved
...eclipse.glsp.server/src/org/eclipse/glsp/server/gmodel/GModelChangeRoutingPointsHandler.java
Show resolved
Hide resolved
8621b85
to
357055e
Compare
@tortmayr Thank you very much for your feedback, I adapted the code accordingly. Regarding a dedicated operation for the routing points, I opted against it since the client-side layout information is currently all part of the |
357055e
to
c4b2bd5
Compare
c4b2bd5
to
22e5059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Code looks good to me an works like a charm.
Implement routing points support for the node glsp server and ensure that the API mirrors the latest changes of the java glsp server (eclipse-glsp/glsp-server#181) Fixes eclipse-glsp/glsp#738
Implement routing points support for the node glsp server and ensure that the API mirrors the latest changes of the java glsp server (eclipse-glsp/glsp-server#181) Fixes eclipse-glsp/glsp#738
Implement routing points support for the node glsp server and ensure that the API mirrors the latest changes of the java glsp server (eclipse-glsp/glsp-server#181) Fixes eclipse-glsp/glsp#738
Implement routing points support for the node glsp server and ensure that the API mirrors the latest changes of the java glsp server (eclipse-glsp/glsp-server#181) Fixes eclipse-glsp/glsp#738
Implement routing points support for the node glsp server and ensure that the API mirrors the latest changes of the java glsp server (eclipse-glsp/glsp-server#181) Fixes eclipse-glsp/glsp#738
Part of eclipse-glsp/glsp#738