Add validation reason and distinguish between live and batch validation #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
requested changes
Apr 21, 2023
.../org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/validation/ModelValidator.java
Show resolved
Hide resolved
.../org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/validation/ModelValidator.java
Show resolved
Hide resolved
| } else { | ||
| markers.addAll(doBatchValidation(element)); | ||
| } | ||
| if (element.getChildren() != null) { |
There was a problem hiding this comment.
I think this is a unnecessary null-check. List properties of EObjects are always defined and should never be null. We should rather check if the children list is not empty.
|
|
||
| public RequestMarkersAction() { | ||
| this(new ArrayList<>()); | ||
| } | ||
|
|
||
| public RequestMarkersAction(final List<String> elementsIDs) { | ||
| this(elementsIDs, null); |
There was a problem hiding this comment.
In the client change you mentioned that the default reason is batch. So we should use it here has default value instead of null.
|
|
||
| } | ||
| String reason = action.getReason() != null ? action.getReason() : MarkersReason.BATCH; |
There was a problem hiding this comment.
See comment above. If the default is already properly set in the action class we don't need to handle it explicitly here.
|
Thank you for the excellent review! I've applied your suggestions with b8a020f. |
tortmayr
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-glsp/glsp#980
For review, please see the comment on which changes belong together.