Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds SetViewportAction #99

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Adds SetViewportAction #99

merged 2 commits into from
Feb 19, 2021

Conversation

planger
Copy link
Member

@planger planger commented Feb 19, 2021

tortmayr
tortmayr requested changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the copyright headers need to be updated to 2021

plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/SetViewportAction.java Outdated Show resolved Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/utils/Viewport.java Outdated Show resolved Hide resolved
@planger
Copy link
Member Author

planger commented Feb 19, 2021

Thanks! Nicely spotted!
I transferred the copyright from the past into the presence, may the code serve us in the future :)

@tortmayr tortmayr merged commit d1f7a41 into master Feb 19, 2021
@tortmayr tortmayr deleted the planger/issues/179/viewport branch February 19, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

@CamilleLetavernier CamilleLetavernier Awaiting requested review from CamilleLetavernier

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@planger @tortmayr