Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#377 Update prettier config #96

Merged
merged 1 commit into from
Oct 7, 2021
Merged

#377 Update prettier config #96

merged 1 commit into from
Oct 7, 2021

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Oct 7, 2021

Update to latest @eclipse-glsp/config version. This version ships with prettier as dependency which enables to configure a workspace-local prettier version for the vscode prettier extension. This ensures that all developers are using the same prettier version.

.settings:

  • Remove prettier as general default formatter to avoid unintended usage of prettier - for languages like java.
  • Configure prettier as default formatter for CSS
  • Set the prettier path to "node_modules/prettier"

Reformat all code:
Reformat code with "yarn prettier --config .prettierrc ./ --write" in root to ensure that all files for which prettier is set as default formatter are properly formatted.

Update to latest @eclipse-glsp/config version. This version ships with prettier as dependency which enables to configure a workspace-local prettier version for the vscode prettier extension. This ensures that all developers are using the same prettier version.

.settings:
- Remove prettier as general default formatter to avoid unintended usage of prettier - for languages like java.
- Configure prettier as default formatter for CSS
- Set the prettier path to "node_modules/prettier"

Reformat all code:
Reformat code with "yarn prettier --config .prettierrc ./ --write" in root to ensure that all files for which prettier is set as default formatter are properly formatted.
@tortmayr tortmayr requested a review from planger October 7, 2021 14:42
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@planger planger merged commit b7efa36 into master Oct 7, 2021
@planger planger deleted the tortmayr/377-follow-up branch October 7, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants