Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the UUID requirement / ApplicationID #109

Closed
CamilleLetavernier opened this issue Aug 28, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#76
Closed

Remove the UUID requirement / ApplicationID #109

CamilleLetavernier opened this issue Aug 28, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#76

Comments

@CamilleLetavernier
Copy link
Member

The recent changes on #94 / #96 introduce a new constraint, where all clientIds have to be universally unique. ClientIDs are now prefixed with an Application ID.

This may cause some issues in existing applications, and this requirement is a bit too strict, as it introduces random IDs in the GSLP Widget/Client ID.

This was initially required, to retrieve the correct GLSPClient from the clientId, on the server side. However, we now inject the GLSPClient in the DI Container, so this mapping is no longer required. Thus, we can revert to the original behavior, where clientIds simply have to be unique within a single client (i.e. Browser Tab)

This issue is mostly about the Server-side requirement. Clients may still generate/use UUIDs if they want to; but the server shouldn't require it.
CamilleLetavernier added a commit to CamilleLetavernier/glsp-server that referenced this issue Aug 28, 2020
@CamilleLetavernier
eclipse-glsp#109 Remove the UUID requirement / ApplicationID
dbbe15b 
- Remove the clientId to GLSPClient mapping in ClientSessionManager

fixes eclipse-glsp/glsp/issues/109

Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
@CamilleLetavernier CamilleLetavernier mentioned this issue Aug 28, 2020
Merged
tortmayr pushed a commit to eclipse-glsp/glsp-server that referenced this issue Aug 28, 2020
@CamilleLetavernier
#109 Remove the UUID requirement / ApplicationID (#76)
78bc9c2 
* #109 Remove the UUID requirement / ApplicationID

- Remove the clientId to GLSPClient mapping in ClientSessionManager

fixes eclipse-glsp/glsp/issues/109

Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>

* #109 Remove unnecessary computeIfAbsent

Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#109 Remove the UUID requirement / ApplicationID CamilleLetavernier/glsp-server
1 participant
@CamilleLetavernier