Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated CompositeFuture static methods #3566

Closed
sophokles73 opened this issue Oct 10, 2023 · 1 comment
Closed

Replace deprecated CompositeFuture static methods #3566

sophokles73 opened this issue Oct 10, 2023 · 1 comment
Labels
enhancement good first issue Issues that do not require much in-depth knowledge of Hono help wanted Issues that we would welcome any help from (new) contributors with
Milestone
2.5.0

Comments

@sophokles73
Copy link
Contributor

As part of #3547 we have also upgraded to Vert.x 4.4.4.

In Vert.x 4.4.3 the CompositeFuture.all methods have been deprecated in favor of corresponding fully typed Future.all methods.

See https://github.com/vert-x3/wiki/wiki/4.4.3-Deprecations-and-breaking-changes

We should change usage in Hono accordingly.
@sophokles73 sophokles73 added enhancement help wanted Issues that we would welcome any help from (new) contributors with good first issue Issues that do not require much in-depth knowledge of Hono labels Oct 10, 2023
@sophokles73 sophokles73 added this to the 2.5.0 milestone Oct 10, 2023
sophokles73 pushed a commit that referenced this issue Oct 19, 2023
@harism @sophokles73
[#3566] Replace direct Vert.x CompositeFuture method calls with Futur…
6ffdace 
…e method calls
@sophokles73
Copy link
Contributor Author

closed via #3571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Issues that do not require much in-depth knowledge of Hono help wanted Issues that we would welcome any help from (new) contributors with
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@sophokles73