Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EXPECT_DEATH #1613

Closed
3 of 4 tasks
elfenpiff opened this issue Sep 7, 2022 · 1 comment · Fixed by #1879, #1891 or #2019
Closed
3 of 4 tasks

Remove EXPECT_DEATH #1613

elfenpiff opened this issue Sep 7, 2022 · 1 comment · Fixed by #1879, #1891 or #2019
Labels
bug Something isn't working enhancement New feature technical debt unclean code and design flaws
Milestone

Comments

@elfenpiff
Copy link
Contributor

elfenpiff commented Sep 7, 2022

Required information

In our cases using EXPECT_DEATH come often with undefined behavior which is unacceptable for certified tests. Possible approaches are:

ToDo

  • (high prio) Define an alternative technique to EXPECT_DEATH and document it in the iceoryx testing document
  • (high prio) Remove all occurrences of EXPECT_DEATH in cxx tests
  • (medium prio) Remove all occurrences of EXPECT_DEATH in remaining hoofs
  • (low prio) Remove all occurrences of EXPECT_DEATH in the remaining iceoryx repo
    • Using EXPECT_FATAL_FAILURE in combination with the RouDiEnvironment results in triggering the leak sanitizer
    • The same is the case when the SUT allocate in the call which leads to the fatal failure, e.g. the ctor of FileReader

Can be split up in further issues when required.

Extracted from: #1196

@elfenpiff elfenpiff added bug Something isn't working enhancement New feature technical debt unclean code and design flaws globex labels Sep 7, 2022
@elfenpiff elfenpiff added this to the High prio milestone Sep 7, 2022
@elBoberido
Copy link
Member

@elfenpiff last week @MatthiasKillat tried the approach with returning from a running thread. This might be the solution to remove the EXPECT_DEATH once the error handler is merged.

elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 6, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
…r to make leak sanitizer play nice with EXPECT_FATAL_FAILURE
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2023
@elBoberido elBoberido reopened this Feb 9, 2023
@elBoberido elBoberido removed the globex label Feb 9, 2023
@elBoberido elBoberido modified the milestones: High prio, Medium prio Feb 9, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 13, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 13, 2023
@elBoberido elBoberido mentioned this issue Feb 13, 2023
21 tasks
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 13, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 13, 2023
@elBoberido elBoberido linked a pull request Feb 13, 2023 that will close this issue
21 tasks
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Sep 5, 2023
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Sep 5, 2023
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Sep 5, 2023
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Sep 5, 2023
elBoberido added a commit that referenced this issue Sep 6, 2023
@github-project-automation github-project-automation bot moved this to Done in v3.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature technical debt unclean code and design flaws
Projects
Status: Done
2 participants