iox-#1196 Add lint suppressions and fix warnings for PoorMansHeap #1467
+34
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
added
refactoring
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
==========================================
- Coverage 78.78% 78.78% -0.01%
==========================================
Files 377 377
Lines 14474 14474
Branches 2009 2009
==========================================
- Hits 11404 11403 -1
- Misses 2433 2434 +1
Partials 637 637
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mossmaurice
reviewed
Jul 7, 2022
FerdinandSpitzschnueffler
previously approved these changes
Jul 7, 2022
elBoberido
changed the title
elBoberido
requested review from
mossmaurice and
FerdinandSpitzschnueffler
and removed request for
elfenpiff
mossmaurice
added
clang-tidy
mossmaurice
reviewed
Jul 7, 2022
elfenpiff
previously approved these changes
Jul 7, 2022
iceoryx_hoofs/include/iceoryx_hoofs/internal/cxx/poor_mans_heap.inl
Outdated
Show resolved
Hide resolved
mossmaurice
reviewed
Jul 7, 2022
| @@ -23,7 +23,7 @@ namespace iox | |||
| { | |||
| namespace cxx | |||
| { | |||
| // AXIVION Construct Ruleset-A12.1.1 : it is guaranteed that the array elements are initialized on access | |||
| // AXIVION Construct AutosarC++19_03-A12.1.1 : it is guaranteed that the array elements are initialized on access | |||
There was a problem hiding this comment.
@elBoberido I don't get A12.1.1 reported in stack when removing this rule and running the check locally.
@dkroenke @neillangmead41 Could you check that?
mossmaurice
reviewed
Jul 7, 2022
| @@ -50,12 +50,12 @@ class stack // NOLINT (cppcoreguidelines-pro-type-member-init,hicpp-member-init) | |||
| static constexpr uint64_t capacity() noexcept; | |||
|
|
|||
| private: | |||
| // AXIVION Next Line Ruleset-A18.1.1 : safe access is guaranteed since the char array is wrapped inside the stack | |||
| // class | |||
| // AXIVION Next Line AutosarC++19_03-A18.1.1 : safe access is guaranteed since the char array is wrapped inside the | |||
There was a problem hiding this comment.
@neillangmead41 @dkroenke This suppression works fine.
mossmaurice
approved these changes
Jul 7, 2022
FerdinandSpitzschnueffler
approved these changes
Jul 7, 2022
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch)iox-#123 commit text)git commit -s)task-list-completed)Notes for Reviewer
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References