Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace std::function occurrences #131

Closed
2 tasks done
mossmaurice opened this issue Jun 9, 2020 · 3 comments
Closed
2 tasks done

Replace std::function occurrences #131

mossmaurice opened this issue Jun 9, 2020 · 3 comments
Assignees
@mossmaurice @MatthiasKillat
Labels
refactoring Refactor code without adding features
Milestone
Medium prio

Comments

@mossmaurice
Copy link
Contributor

mossmaurice commented Jun 9, 2020 •
edited
Loading

Brief feature description

std::function is hard to validate for ASIL, hence replace it in targets with quality level 1, 2 and 3.

Detailed information

  • Replace all occurrences with cxx::function_ref when used as function parameter
  • Find a solution for all other places e.g. posix::Timer
@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Jun 9, 2020
@mossmaurice mossmaurice self-assigned this Jun 9, 2020
@mossmaurice mossmaurice mentioned this issue Jun 9, 2020
Merged
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Jun 10, 2020
@mossmaurice
iox-eclipse-iceoryx#131 Replace std::function with cxx::function_ref …
bbaf32a 
…in optional

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Jun 10, 2020
@mossmaurice
iox-eclipse-iceoryx#131 Address leftover findings of eclipse-iceoryx#124
e7fbc3e 


Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
@mossmaurice mossmaurice mentioned this issue Jun 13, 2020
Closed
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Jun 13, 2020
@mossmaurice
iox-eclipse-iceoryx#131 Add sane overload resolution behavior to func…
73dc4af 
…tion_ref and add its respective test case

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Jun 15, 2020
@mossmaurice
iox-eclipse-iceoryx#131 Replace std::function with cxx::function_ref …
1dde614 
…in cxx::expected

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Jun 15, 2020
@mossmaurice
iox-eclipse-iceoryx#131 Correct syntax, remove obsolete code and fix …
80e0301 
…test build

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Jun 15, 2020
@mossmaurice
Merge remote-tracking branch 'upstream/master' into iox-eclipse-iceor…
eb07376 
…yx#131-remove-std-function-in-function-params
@mossmaurice
Copy link
Contributor Author

Step 2) consists of

  • ErrorHandler
  • posix::Timer
  • Iceoryx2DDSGateway
  • Subscriber_t::setReceiveHandler
  • PoshRuntime::s_runtimeFactory
  • GenericRAII
  • ActiveObject

mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Jun 15, 2020
@mossmaurice
iox-eclipse-iceoryx#131 Address review findings and fix release build
dfe04e3 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit that referenced this issue Jun 16, 2020
@mossmaurice
Merge pull request #139 from mossmaurice/iox-#131-remove-std-function…
c7bed40 
…-in-function-params

Iox #131 Remove std::function in expected and optional
@mossmaurice mossmaurice mentioned this issue Sep 16, 2020
Merged
@mossmaurice
Copy link
Contributor Author

Just discussed this topic with @elBoberido

Step 2) consists of

* `ErrorHandler`

function_ref can be used

* `posix::Timer`

will be removed

* `Iceoryx2DDSGateway`

not relevant, quality level 4

* `Subscriber_t::setReceiveHandler`

will be removed with iceoryx 1.0 release

* `PoshRuntime::s_runtimeFactory`

function_ref can be used

* `GenericRAII`

function_ref can be used for c'tor but not for d'tor open point

* `ActiveObject`

open point, reference counting on callable user might solve the lifetime issue (save_ref)

@mossmaurice mossmaurice added this to the v1.x milestone Nov 4, 2020
@MatthiasKillat MatthiasKillat mentioned this issue Nov 23, 2020
Closed
@elfenpiff elfenpiff mentioned this issue May 7, 2021
Closed
@mossmaurice
Copy link
Contributor Author

Duplicate of #831 closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossmaurice mossmaurice

@MatthiasKillat MatthiasKillat

Labels
refactoring Refactor code without adding features
Projects
None yet
Milestone
Medium prio
Development

No branches or pull requests
2 participants
@mossmaurice @MatthiasKillat