Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove asynchronous service discovery feature #90

Closed
prasannabhat opened this issue May 6, 2020 · 0 comments · Fixed by #101
Closed

Remove asynchronous service discovery feature #90

prasannabhat opened this issue May 6, 2020 · 0 comments · Fixed by #101
Assignees
@prasannabhat
Labels
refactoring Refactor code without adding features

Comments

@prasannabhat
Copy link
Contributor

Brief feature description

Remove asynchronous service discovery feature

Detailed information

iceoryx currently implements asynchronous service discovery feature (implemented with PoshRuntime::startFindService() & PoshRuntime::stopFindService() ), in addition to synchronous service discovery.
This feature belongs to higher layers, (which could implement this feature using iceoryx api)
Remove this for cleaning up iceoryx
@mossmaurice mossmaurice added the refactoring Refactor code without adding features label May 6, 2020
elBoberido pushed a commit to elBoberido/iceoryx that referenced this issue May 14, 2020
@pral1kor
iox-eclipse-iceoryx#90 Remove service discovery notification feature …
6a2a718 
…from PoshRuntime

Signed-off-by: Prasanna Bhat (RBEI/EBB) <prasanna.bhat@in.bosch.com>
@elBoberido elBoberido mentioned this issue May 14, 2020
Merged
@mossmaurice mossmaurice linked a pull request May 14, 2020 that will close this issue
iox-#90 Remove service discovery notification feature from PoshRuntime #101
Merged
elBoberido added a commit that referenced this issue May 14, 2020
@elBoberido
Merge pull request #101 from elBoberido/iox-#90-remove-async-service-…
0196e83 
…discovery

iox-#90 Remove service discovery notification feature from PoshRuntime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prasannabhat prasannabhat

Labels
refactoring Refactor code without adding features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iox-#90 Remove service discovery notification feature from PoshRuntime elBoberido/iceoryx
2 participants
@prasannabhat @mossmaurice