Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#605 Move RelativePointer from internal to public include directory #1719

Merged

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Oct 5, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

  • Move RelativePointer from internal to public include directory

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Oct 5, 2022
@mossmaurice mossmaurice self-assigned this Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #1719 (0c6659b) into master (5c1396c) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1719      +/-   ##
==========================================
+ Coverage   77.40%   77.45%   +0.05%     
==========================================
  Files         366      366              
  Lines       14161    14161              
  Branches     1984     1984              
==========================================
+ Hits        10961    10969       +8     
+ Misses       2570     2562       -8     
  Partials      630      630              
Flag Coverage Δ
unittests 77.11% <ø> (+0.05%) ⬆️
unittests_timing 15.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...clude/iceoryx_hoofs/internal/concurrent/loffli.hpp 100.00% <ø> (ø)
.../include/iceoryx_hoofs/memory/relative_pointer.hpp 100.00% <ø> (ø)
.../include/iceoryx_hoofs/memory/relative_pointer.inl 96.42% <ø> (ø)
...lude/iceoryx_posh/internal/mepoo/mepoo_segment.inl 91.11% <ø> (ø)
...clude/iceoryx_posh/internal/mepoo/shared_chunk.hpp 100.00% <ø> (ø)
...ceoryx_posh/internal/popo/ports/base_port_data.hpp 100.00% <ø> (ø)
...posh/include/iceoryx_posh/internal/roudi/roudi.hpp 77.77% <ø> (ø)
...eoryx_posh/internal/runtime/ipc_interface_base.hpp 100.00% <ø> (ø)
iceoryx_posh/source/mepoo/shared_chunk.cpp 96.66% <ø> (ø)
...eoryx_posh/source/roudi/memory/memory_provider.cpp 94.44% <ø> (ø)
... and 3 more

…include directory

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice merged commit 1da4f68 into eclipse-iceoryx:master Oct 6, 2022
@mossmaurice mossmaurice deleted the iox-605-move-relative-pointer branch October 6, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Relocatable Pointer and Relative Pointer
3 participants