iox-#2241 Fix span iterator constructor

[pbarone-latai]

Notes for Reviewer

This PR fixes an incorrect assert which prevented the creation of the end iterator of a span

Fixes #2241

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Checklist for the PR Reviewer

• Consider a second reviewer for complex new features or larger refactorings
• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes span_iterator assert doesn't allow construction of an end() iterator #2241

[elfenpiff]

@pbarone-latai Thanks for the bug-fix!

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.52%. Comparing base (166c6ca) to head (cd9ff9f).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2243   +/-   ##
=======================================
  Coverage   78.51%   78.52%           
=======================================
  Files         431      431           
  Lines       16629    16631    +2     
  Branches     2333     2333           
=======================================
+ Hits        13057    13059    +2     
  Misses       2707     2707           
  Partials      865      865           

Flag	Coverage Δ
unittests	78.31% <0.00%> (+<0.01%)	⬆️
unittests_timing	15.33% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...fs/vocabulary/include/iox/detail/span_iterator.hpp	68.75% <0.00%> (ø)

... and 3 files with indirect coverage changes