Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2299 Add port counts to introspection client #2300

Conversation

tobiasstarkwayve
Copy link
Contributor

@tobiasstarkwayve tobiasstarkwayve commented Jun 5, 2024

Notes for Reviewer

This PR adds the number of ports to the introspection client display. This makes it easier to get a quick overview over the number of active ports if there are too many to count by hand.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@tobiasstarkwayve tobiasstarkwayve force-pushed the iox-2299-add-port-count-to-introspection-client branch from 7315ebc to 83cedb0 Compare June 5, 2024 12:24
@elfenpiff
Copy link
Contributor

@tobiasstarkwayve Thanks for the contribution. Everything seems to be in order, but the clang-format preflight check complains. In the root dir of the repo, there is already a .clang-format file. Could you please format the file with your IDE? It should work out of the box with any clang-format extension.

You must also sign the Eclipse contribution agreement (https://www.eclipse.org/legal/ECA.php) using the email address you used for your commit message.

As soon as this is done, we can merge the PR.

Signed-off-by: Tobias Stark <tobias.stark@wayve.ai>
@tobiasstarkwayve tobiasstarkwayve force-pushed the iox-2299-add-port-count-to-introspection-client branch from 83cedb0 to 78ae6b7 Compare June 6, 2024 08:44
@tobiasstarkwayve
Copy link
Contributor Author

@tobiasstarkwayve Thanks for the contribution. Everything seems to be in order, but the clang-format preflight check complains. In the root dir of the repo, there is already a .clang-format file. Could you please format the file with your IDE? It should work out of the box with any clang-format extension.

You must also sign the Eclipse contribution agreement (https://www.eclipse.org/legal/ECA.php) using the email address you used for your commit message.

As soon as this is done, we can merge the PR.

Done. I actually signed the ECA yesterday already, but I think it took some time to propagate the information (or pushing a new commit forced it to re-evaluate). Either way, the box is green now :-)

Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the long list of iceoryx contributors. We hope there will be more from you in the future :)

Btw, if you install the git hooks from tools/git-hooks, they will take care of adding the issue number to the commit message, running clang-format and doing some additional checks. It's quite handy even one does not regularly contribute.

@elBoberido elBoberido merged commit 7b0dabe into eclipse-iceoryx:main Jun 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: print the number of ports in the introspection client
3 participants