-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #341 improve waitset wait performance by returning TriggerInfo pointer #436
Merged
elfenpiff
merged 43 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#341-waitset-templatize-wait-for-better-performance
Dec 18, 2020
Merged
Iox #341 improve waitset wait performance by returning TriggerInfo pointer #436
elfenpiff
merged 43 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#341-waitset-templatize-wait-for-better-performance
Dec 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Eltzschig <me@elchris.org>
…clipse-iceoryx#341-waitset-templatize-wait-for-better-performance
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
requested review from
mossmaurice,
budrus,
elBoberido and
MatthiasKillat
December 15, 2020 17:35
…clipse-iceoryx#341-waitset-templatize-wait-for-better-performance
Signed-off-by: Christian Eltzschig <me@elchris.org>
…clipse-iceoryx#341-waitset-templatize-wait-for-better-performance
…trigger info storage struct Signed-off-by: Christian Eltzschig <me@elchris.org>
…clipse-iceoryx#341-waitset-templatize-wait-for-better-performance
…clipse-iceoryx#341-waitset-templatize-wait-for-better-performance
…the trigger instead of invalidating it Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…ter-performance' of github.com:ApexAI/iceoryx into iox-eclipse-iceoryx#341-waitset-templatize-wait-for-better-performance
… binding accordingly Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…e shutdown trigger Signed-off-by: Christian Eltzschig <me@elchris.org>
budrus
reviewed
Dec 16, 2020
elBoberido
reviewed
Dec 16, 2020
iceoryx_posh/include/iceoryx_posh/popo/modern_api/base_subscriber.hpp
Outdated
Show resolved
Hide resolved
…o into eventInfo Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…unctions Signed-off-by: Christian Eltzschig <me@elchris.org>
… enableTriggerEvent/disableTriggerEvent Signed-off-by: Christian Eltzschig <me@elchris.org>
…chEvent into disableEvent Signed-off-by: Christian Eltzschig <me@elchris.org>
…sNewSamples method to hasSamples Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…cumented Signed-off-by: Christian Eltzschig <me@elchris.org>
…hing works only via waitset Signed-off-by: Christian Eltzschig <me@elchris.org>
…er to provide default arguments Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
… fixed an issue in the gateway example Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
elBoberido
reviewed
Dec 17, 2020
… renamed trigger left overs into event and adjusted docu Signed-off-by: Christian Eltzschig <me@elchris.org>
…lot of Us Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…clipse-iceoryx#341-waitset-templatize-wait-for-better-performance
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…clipse-iceoryx#341-waitset-templatize-wait-for-better-performance
Signed-off-by: Christian Eltzschig <me@elchris.org>
budrus
reviewed
Dec 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Signed-off-by: Christian Eltzschig <me@elchris.org>
budrus
approved these changes
Dec 18, 2020
elBoberido
approved these changes
Dec 18, 2020
elfenpiff
deleted the
iox-#341-waitset-templatize-wait-for-better-performance
branch
December 18, 2020 12:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)Notes for Reviewer
Info Please review: #435 first since this PR is based on that one.
To improve the performance of the
wait
call we reduced the element size from 48 byte to 8 bytes by returning a pointer to aTriggerInfo
object instead of a copy.To realize this we had to turn the
TriggerVector
inside of the waitset into aTriggerList
.Checklist for the PR Reviewer
Post-review Checklist for the PR Author
Post-review Checklist for the Eclipse Committer
References