Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #341 improve waitset wait performance by returning TriggerInfo pointer #436

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 15, 2020

Pre-Review Checklist for the PR Author

  1. Branch follows the naming format (iox-#123-this-is-a-branch)
  2. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  3. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  4. Relevant issues are linked
  5. Add sensible notes for the reviewer
  6. All checks have passed
  7. Assign PR to reviewer

Notes for Reviewer

Info Please review: #435 first since this PR is based on that one.
To improve the performance of the wait call we reduced the element size from 48 byte to 8 bytes by returning a pointer to a TriggerInfo object instead of a copy.
To realize this we had to turn the TriggerVector inside of the waitset into a TriggerList.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

  1. All checkboxes in the PR checklist are checked or crossed out
  2. Merge

References

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…trigger info storage struct

Signed-off-by: Christian Eltzschig <me@elchris.org>
…the trigger instead of invalidating it

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…ter-performance' of github.com:ApexAI/iceoryx into iox-eclipse-iceoryx#341-waitset-templatize-wait-for-better-performance
… binding accordingly

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…e shutdown trigger

Signed-off-by: Christian Eltzschig <me@elchris.org>
…o into eventInfo

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…unctions

Signed-off-by: Christian Eltzschig <me@elchris.org>
… enableTriggerEvent/disableTriggerEvent

Signed-off-by: Christian Eltzschig <me@elchris.org>
…chEvent into disableEvent

Signed-off-by: Christian Eltzschig <me@elchris.org>
…sNewSamples method to hasSamples

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…cumented

Signed-off-by: Christian Eltzschig <me@elchris.org>
…hing works only via waitset

Signed-off-by: Christian Eltzschig <me@elchris.org>
…er to provide default arguments

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
… fixed an issue in the gateway example

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
iceoryx_examples/waitset/README.md Outdated Show resolved Hide resolved
iceoryx_examples/waitset/README.md Outdated Show resolved Hide resolved
… renamed trigger left overs into event and adjusted docu

Signed-off-by: Christian Eltzschig <me@elchris.org>
…lot of Us

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Copy link
Contributor

@budrus budrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

iceoryx_binding_c/include/iceoryx_binding_c/wait_set.h Outdated Show resolved Hide resolved
iceoryx_binding_c/include/iceoryx_binding_c/wait_set.h Outdated Show resolved Hide resolved
Signed-off-by: Christian Eltzschig <me@elchris.org>
@budrus budrus self-requested a review December 18, 2020 10:55
@elfenpiff elfenpiff merged commit cb2a116 into eclipse-iceoryx:master Dec 18, 2020
@elfenpiff elfenpiff deleted the iox-#341-waitset-templatize-wait-for-better-performance branch December 18, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants