Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#454 improve coverage of class roudi memory provider, memory block and memory manager #487

Conversation

nihalchari
Copy link

@nihalchari nihalchari commented Jan 12, 2021

Pre-Review Checklist for the PR Author

  1. Branch follows the naming format (iox-#123-this-is-a-branch)
  2. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  3. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  4. Relevant issues are linked
  5. Add sensible notes for the reviewer
  6. All checks have passed
  7. Assign PR to reviewer

Notes for Reviewer

code contributed by @JimmyBch

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

  1. All checkboxes in the PR checklist are checked or crossed out
  2. Merge

References

…er, block and manager

Signed-off-by: Jimmy Belloche <external.jimmy.belloche@de.bosch.com>
@nihalchari
Copy link
Author

nihalchari commented Jan 12, 2021

closed PR #478 and created new

@nihalchari nihalchari changed the title iox-#454 improve coverage of class roudi memory provider, block and m… iox-#454 improve coverage of class roudi memory provider, memory block and memory manager Jan 13, 2021
@JimmyBch
Copy link
Contributor

@elBoberido @dkroenke Do you mind to review this PR and give your approval whether everything is ok ? :)

@dkroenke dkroenke added the test A module/integration/stress/etc test for a component label Jan 13, 2021
@dkroenke dkroenke self-requested a review January 13, 2021 08:18
@dkroenke
Copy link
Member

@nihalchari or @JimmyBch please fill in the Pre-Review Checklist of the PR description

dkroenke
dkroenke previously approved these changes Jan 13, 2021
elBoberido
elBoberido previously approved these changes Jan 13, 2021
@FerdinandSpitzschnueffler
Copy link
Contributor

Can you please update the copyright headers in the changed files so that they include the years of the creation and of the last modification, i.e. 2019, 2021?

@elBoberido
Copy link
Member

@FerdinandSpitzschnueffler we didn't do it for files which were created in 2019 and adapted in 2020, so I'm not sure if we have to. I would prefer not to do it if not necessary.

Signed-off-by: Jimmy Belloche <external.jimmy.belloche@de.bosch.com>
dkroenke
dkroenke previously approved these changes Jan 13, 2021
@dkroenke dkroenke self-requested a review January 13, 2021 13:24
Signed-off-by: Jimmy Belloche <external.jimmy.belloche@de.bosch.com>
@elBoberido elBoberido merged commit 92b4455 into eclipse-iceoryx:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test A module/integration/stress/etc test for a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing Tests in Roudi
5 participants