Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pretty print for service with example #29

Closed

Conversation

hydroid7
Copy link
Contributor

@hydroid7 hydroid7 commented Dec 13, 2023

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #18

@hydroid7 hydroid7 changed the title Adds pretty print with example Adds pretty print for service with example Dec 13, 2023
@hydroid7 hydroid7 closed this Dec 13, 2023
@hydroid7 hydroid7 deleted the feature/service-pretty-print branch December 13, 2023 10:22
@elfenpiff
Copy link
Contributor

@hydroid7 Your code looked good, why did you remove the PR?

hydroid7 added a commit to hydroid7/iceoryx2 that referenced this pull request Dec 16, 2023
hydroid7 added a commit to hydroid7/iceoryx2 that referenced this pull request Dec 16, 2023
hydroid7 added a commit to hydroid7/iceoryx2 that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement display for port factory for all messaging patterns
2 participants