-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open declaration results in ClassCastException: LocalDeclaration cannot be cast to LambdaExpression #1195
Comments
Still in latest master, but now only with one error:
|
I'll take a look. |
i got similar error:
|
Is pattern matching instanceof used in the vicinity ?? |
It happens when hovering for example anything in line 99-118 of org.eclipse.jdt.internal.launching.DetectVMInstallationsJob |
I wish you had copied and pasted the lines involved instead of quoting line numbers! :) I think what you encountered is pretty much the same problem as #1263 which will be fixed by #1349 I do see there is a instanceof with a pattern binding variable in line 90 in the present state of affairs. |
|
Thank you, but line 91 and 112 both have a pattern matching instanceof - In fact I don't see a "classic" instanceof at all in this file. |
This is a substantial reimplementation of the code selection support for pattern matching constructs. By using auxiliary stacks to record the state of the parser and by using that state to drive the bottom up context recovery and parse tree construction, we now rebuild the parse tree to sufficient detail to ascertain liveness of pattern binding variables at the point of selection. Fixes #1195 Fixes #769 Fixes #1263 Fixes #1360 Fixes #1364 Fixes #1278 Fixes #1288 Verifies https://bugs.eclipse.org/bugs/show_bug.cgi?id=573257 Verifies https://bugs.eclipse.org/bugs/show_bug.cgi?id=572975 Verifies https://bugs.eclipse.org/bugs/show_bug.cgi?id=576794
The fix made here also addresses #860 |
…e-jdt#1349) This is a substantial reimplementation of the code selection support for pattern matching constructs. By using auxiliary stacks to record the state of the parser and by using that state to drive the bottom up context recovery and parse tree construction, we now rebuild the parse tree to sufficient detail to ascertain liveness of pattern binding variables at the point of selection. Fixes eclipse-jdt#1195 Fixes eclipse-jdt#769 Fixes eclipse-jdt#1263 Fixes eclipse-jdt#1360 Fixes eclipse-jdt#1364 Fixes eclipse-jdt#1278 Fixes eclipse-jdt#1288 Verifies https://bugs.eclipse.org/bugs/show_bug.cgi?id=573257 Verifies https://bugs.eclipse.org/bugs/show_bug.cgi?id=572975 Verifies https://bugs.eclipse.org/bugs/show_bug.cgi?id=576794
Eclipse 2023-06, reproducer:
Using F3 on "predicate" will lead to the below exception.
Removing the variable name after the instanceof check fixes the issue, therefore the root cause of the bug might be related to changes for pattern matching with instanceof.
EDIT: I later found another exception in the log, which might be related. However, I cannot say which piece of source triggered this one:
The text was updated successfully, but these errors were encountered: