Fix for pasting snippet with main method to Package Explorer #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveeclipse
changed the title
...eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/PasteAction.java
Outdated
Show resolved
Hide resolved
|
Seems to work. Personally I don't miss randomly pasting code into the Package Explorer (its always a mistake when I do this, I forgot to select a package to paste into), but I guess the exception is bad and should be fixed. |
After introducing implicit types via eclipse-jdt/eclipse.jdt.core#2066 the snippet that contains only main() method is recognized as ImplicitTypeDeclaration that does not inherit AbstractTypeDeclaration but common super class AbstractUnnamedTypeDeclaration. Make sure we don't fail with CCE and don't generate extra main method that wraps around pasted main method. Fixes eclipse-jdt#1414
trancexpress
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing implicit types via
eclipse-jdt/eclipse.jdt.core#2066 the snippet that contains only main() method is recognized as
ImplicitTypeDeclaration that does not inherit AbstractTypeDeclaration but common super class AbstractUnnamedTypeDeclaration.
Make sure we don't fail with CCE and don't generate extra main method that wraps around pasted main method.
Fixes #1414