Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement exit notification and remove process exit from shutdown #35

Closed
gorkem opened this issue Jul 8, 2016 · 2 comments
Closed

Implement exit notification and remove process exit from shutdown #35

gorkem opened this issue Jul 8, 2016 · 2 comments
Milestone
August 2016

Comments

@gorkem
Copy link
Contributor

gorkem commented Jul 8, 2016

No description provided.

@egamma egamma added this to the Hackathon milestone Jul 11, 2016
mkeller added a commit that referenced this issue Jul 12, 2016
@mkeller
#35: Implement exit notification and remove process exit from shutdown
33b8560 
The shutdown message is currently not processed properly because VS Code
prematurely kills the Java Language Server and we don't have a chance
to finish the application thread and shut down the workspace.

This commit also monitors the parent processId to make sure we shut down
when the parent process died.
@mkeller
Copy link

mkeller commented Jul 12, 2016

33b8560 implements part of this, but the shutdown message is currently not processed properly because VS Code prematurely kills the Java Language Server and we don't have a chance to finish the application thread and shut down the workspace.

@gorkem gorkem modified the milestones: August 2016, Hackathon Aug 2, 2016
@gorkem gorkem mentioned this issue Aug 15, 2016
Closed
@gorkem
Copy link
Contributor Author

gorkem commented Aug 15, 2016

Nothing else todo on server opened https://github.com/gorkem/vscode-java/issues/3 to followup on extension

@gorkem gorkem closed this as completed Aug 15, 2016
yaohaizh pushed a commit to yaohaizh/eclipse.jdt.ls that referenced this issue Jul 4, 2017
@gorkem
fix proxyStrictSSL option
5adfb22 
removes an old initialization that caused http.proxyStrictSSL
to be always true.  fixes eclipse-jdtls#35
fbricon pushed a commit to fbricon/eclipse.jdt.ls that referenced this issue Aug 21, 2017
@testforstephen
Support hitCount breakpoint (eclipse-jdtls#35)
dc7a470 
* Support hitCount breakpoint

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Convert client source path to uri path

* fix review comments

* fix String.format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
3 participants
@gorkem @mkeller @egamma