Enhanced IBuildSupport usage to support other build tools such as bazel #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Bushenko <d.bushenko@gmail.com>
|
Can one of the admins verify this patch? |
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/IBuildSupport.java
Outdated
Show resolved
Hide resolved
| @@ -77,16 +77,8 @@ public static boolean isJavaProject(IProject project) { | |||
| return hasNature(project, JavaCore.NATURE_ID); | |||
| } | |||
|
|
|||
| public static boolean isMavenProject(IProject project) { | |||
There was a problem hiding this comment.
i will be cautious to remove public helpers from the utility since it may be used by other extensions.
There was a problem hiding this comment.
@testforstephen definitely cautious am I. The whole idea of improving IBuildSupport is to move the logic of working with particular build tool to the specific plugin. If we leave those methods in the utils class then we are leaving one more place for the maven/gradle logic. Which is bad, you know.
I understand that third-party plugins might rely on those methods. The will have to deal with the fact that they will need to improve their behavior and start relying on corresponding IBuildSupport.
Signed-off-by: Dmitry Bushenko <d.bushenko@gmail.com>
Signed-off-by: Dmitry Bushenko <d.bushenko@gmail.com>
LeonovecSergey
added a commit
to LeonovecSergey/eclipse.jdt.ls
that referenced
this pull request
Mar 16, 2021
Based on eclipse-jdtls#1674 Signed-off-by: Siarhei Leanavets <siarhei_leanavets1@epam.com>
|
superseded by #1694 |
LeonovecSergey
added a commit
to LeonovecSergey/eclipse.jdt.ls
that referenced
this pull request
Mar 28, 2021
Based on eclipse-jdtls#1674 Signed-off-by: Siarhei Leanavets <siarhei_leanavets1@epam.com>
LeonovecSergey
added a commit
to LeonovecSergey/eclipse.jdt.ls
that referenced
this pull request
Apr 13, 2021
Based on eclipse-jdtls#1674 Signed-off-by: Siarhei Leanavets <siarhei_leanavets1@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed hardcoded checks for maven and gradle build tools.
Removed implicit assumption that there only two build tools: maven and gradle.
Enhanced IBuildSupport usage so that we may add more build tools such as bazel.
Signed-off-by: Dmitry Bushenko d.bushenko@gmail.com