Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select suitable JDK to launch Gradle. #2812

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Aug 24, 2023

  • When the Gradle Java home preference is not set, and the default JDK is not compatible with the project Gradle, try to find compatible JDK if there is one available.

@jdneo jdneo force-pushed the cs/pick-gradle-java-home branch 2 times, most recently from e12d046 to 717d36d Compare August 24, 2023 04:58
@jdneo jdneo marked this pull request as draft August 24, 2023 07:31
@jdneo jdneo changed the title Select suitable JDK to launch Gradle. [WIP] Select suitable JDK to launch Gradle. Aug 24, 2023
- When the Gradle Java home preference is not set, and
  the default JDK is not compatible with the project
  Gradle, try to find compatible JDK if there is one available.

Signed-off-by: Sheng Chen <sheche@microsoft.com>
Signed-off-by: Sheng Chen <sheche@microsoft.com>
@jdneo

This comment was marked as off-topic.

@jdneo jdneo marked this pull request as ready for review August 25, 2023 04:38
@jdneo jdneo changed the title [WIP] Select suitable JDK to launch Gradle. Select suitable JDK to launch Gradle. Aug 25, 2023
@jdneo

This comment was marked as off-topic.

@testforstephen testforstephen added this to the End August 2023 milestone Aug 28, 2023
@jdneo jdneo merged commit 792c343 into eclipse-jdtls:master Aug 28, 2023
4 checks passed
@jdneo jdneo deleted the cs/pick-gradle-java-home branch August 28, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants