property jkube.enricher.jkube-controller.pullPolicy is not taken into account if a deployment resource fragment is defined
#1619
Assignees
Labels
Milestone
Comments
sunix
added
the
demoable
|
I think it's not working because a different enricher ControllerViaPluginConfigurationEnricher gets executed when the user provides controller fragment. I think it should work if you use this property instead: Related to fabric8io/fabric8-maven-plugin#401 |
|
So apparently we have at least 4 ways to control the pull policy (fragment, XML configuration, and 2 enricher peroperties). We need to centralize where this configuration is computed and make sure it just works. (IIRC we did something similar for at least one other property). |
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jun 21, 2022
…r's properties in account (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding logic in ControllerViaPluginConfigurationEnricher to also consider DefaultControllerEnricher's configuration while generating resources. This requires adding a utility method in BaseEnricher to read other enricher's configuration by name and then using it in DefaultControllerEnricher and ControllerViaPluginConfigurationEnricher. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jun 22, 2022
…r's properties in account (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding logic in ControllerViaPluginConfigurationEnricher to also consider DefaultControllerEnricher's configuration while generating resources. This requires adding a utility method in BaseEnricher to read other enricher's configuration by name and then using it in DefaultControllerEnricher and ControllerViaPluginConfigurationEnricher. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
15 tasks
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jun 22, 2022
…r's properties in account (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding logic in ControllerViaPluginConfigurationEnricher to also consider DefaultControllerEnricher's configuration while generating resources. This requires adding a utility method in BaseEnricher to read other enricher's configuration by name and then using it in DefaultControllerEnricher and ControllerViaPluginConfigurationEnricher. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jun 22, 2022
…r's properties in account (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding logic in ControllerViaPluginConfigurationEnricher to also consider DefaultControllerEnricher's configuration while generating resources. This requires adding a utility method in BaseEnricher to read other enricher's configuration by name and then using it in DefaultControllerEnricher and ControllerViaPluginConfigurationEnricher. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jun 22, 2022
… for configuring container image pull policies (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jun 22, 2022
… for configuring container image pull policies (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jun 22, 2022
… for configuring container image pull policies (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 12, 2022
… for configuring container image pull policies (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 12, 2022
… for configuring container image pull policies (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 14, 2022
… for configuring container image pull policies (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 15, 2022
… for configuring container image pull policies (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 19, 2022
… for configuring container image pull policies (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa
pushed a commit
that referenced
this issue
Jul 20, 2022
… for configuring container image pull policies (#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 22, 2022
Related to eclipse-jkube#1619 Update CHANGELOG entry for issue in order to clarify the fix and deprecations of old properties. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
15 tasks
manusa
pushed a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 22, 2022
Related to eclipse-jkube#1619 Update CHANGELOG entry for issue in order to clarify the fix and deprecations of old properties. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa
pushed a commit
that referenced
this issue
Jul 22, 2022
Related to #1619 Update CHANGELOG entry for issue in order to clarify the fix and deprecations of old properties. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
baruKreddy
pushed a commit
to baruKreddy/jkube
that referenced
this issue
Aug 11, 2022
… for configuring container image pull policies (eclipse-jkube#1619) When a fragment is used, ControllerViaPluginConfigurationEnricher is used. In this case `jkube.enricher.jkube-controller.*` configuration won't work since we're not using DefaultControllerEnricher (used in zero configuration) anymore. This might be confusing for user. Adding a new property `jkube.imagePullPolicy` which can be used for configuring pull policy Signed-off-by: Rohan Kumar <rohaan@redhat.com>
baruKreddy
pushed a commit
to baruKreddy/jkube
that referenced
this issue
Aug 11, 2022
Related to eclipse-jkube#1619 Update CHANGELOG entry for issue in order to clarify the fix and deprecations of old properties. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Trying to use
jkube.enricher.jkube-controller.pullPolicyto set the image pull policy toAlways. It works. However, once I added adeploymentresource fragment, even not related, it stopped working.Eclipse JKube version
1.8.0
Component
Kubernetes Maven Plugin
Apache Maven version
No response
Gradle version
No response
Steps to reproduce
<jkube.enricher.jkube-controller.pullPolicy>Always</jkube.enricher.jkube-controller.pullPolicy>mvn k8s:resource, the generated configuration with a pullpolicy toAlwaysfor the container image.src/main/jkube/deployment.ymlmvn k8s:resource, the generated configuration with a pullpolicy toIfNotPresentfor the container image.Expected behavior
it should keep the pull policy to
AlwaysRuntime
Kubernetes (vanilla)
Kubernetes API Server version
other (please specify in additional context)
Environment
Linux
Eclipse JKube Logs
No response
Sample Reproducer Project
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: