IngressEnricher ignores IngressRules defined in XML config

[rohanKanojia]

There is this field mentioned in XML config:
https://github.com/eclipse/jkube/blob/65087cc54ac59f773b6b41314e9b27684f3db47f/jkube-kit/config/resource/src/main/java/org/eclipse/jkube/kit/config/resource/ResourceConfig.java#L82

@jwcarman noticed this issue. When you try to provide IngressRules inside XML config like this:

            <plugin>
                <groupId>org.eclipse.jkube</groupId>
                <artifactId>kubernetes-maven-plugin</artifactId>
                <version>1.0.0-SNAPSHOT</version>
                <configuration>
                    <resources>
                        <replicas>${k8s.replicas}</replicas>
                        <routeDomain>hello.example.systems</routeDomain>
                        <serviceAccounts>
                            <serviceAccount>
                                <name>hello-k8s-sa</name>
                                <deploymentRef>${artifactId}</deploymentRef>
                            </serviceAccount>
                        </serviceAccounts>
                        <ingressRules>
                            <ingressRule>
                                <host>hello.example.systems</host>
                                <http>
                                    <paths>
                                        <path>
                                            <path>/</path>
                                            <backend>
                                                <serviceName>${artifactId}</serviceName>
                                                <servicePort>
                                                    <IntVal>80</IntVal>
                                                </servicePort>
                                            </backend>
                                        </path>
                                    </paths>
                                </http>
                            </ingressRule>
                        </ingressRules>
                    </resources>

                    ...

No IngressRule seems to be present inside the created Ingress resource during k8s:resource goal.

Actual generated fragment:

~/work/repos/fmp-samples/hello-k8s : $ cat target/classes/META-INF/jkube/kubernetes/hello-k8s-ingress.yml 
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    jkube.io/git-url: https://github.com/jwcarman/hello-k8s.git
    jkube.io/git-commit: 33a20e2ffed2abea7010586effc3fbc8e8e7f9f0
    jkube.io/git-branch: failing-ingress
    jkube.io/scm-url: https://github.com/spring-projects/spring-boot/hello-k8s
    jkube.io/scm-tag: HEAD
    jkube.io/issue-system: GitHub
    jkube.io/issue-tracker-url: https://github.com/spring-projects/spring-boot/issues
  labels:
    app: hello-k8s
    provider: jkube
    version: 0.0.14-SNAPSHOT
    group: com.example.k8s
  name: hello-k8s
spec:
  rules:
  - host: hello-k8s.hello.example.systems
    http:
      paths:
      - backend:
          serviceName: hello-k8s
          servicePort: 80

Expected generated fragment:

~/work/repos/fmp-samples/hello-k8s : $ cat target/classes/META-INF/jkube/kubernetes/hello-k8s-ingress.yml 
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    jkube.io/git-url: https://github.com/jwcarman/hello-k8s.git
    jkube.io/git-commit: 33a20e2ffed2abea7010586effc3fbc8e8e7f9f0
    jkube.io/git-branch: failing-ingress
    jkube.io/scm-url: https://github.com/spring-projects/spring-boot/hello-k8s
    jkube.io/scm-tag: HEAD
    jkube.io/issue-system: GitHub
    jkube.io/issue-tracker-url: https://github.com/spring-projects/spring-boot/issues
  labels:
    app: hello-k8s
    provider: jkube
    version: 0.0.14-SNAPSHOT
    group: com.example.k8s
  name: hello-k8s
spec:
  rules:
    - host: hello.example.systems
      http:
        paths:
          - backend:
              serviceName: hello-k8s
              servicePort: 80
            path: /

The plugin should also check XML configuration for provided Ingress configuration. Right now we're just using Kubernetes Model's IngressRule object inside our XML configuration. We should probably have our own IngressConfig class to be used inside ResourceConfig so that we don't get affected by changes in Kubernetes model over time.

[manusa]

Relates to: #184 #213