Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #231: IngressEnricher ignores IngressRules defined in XML config #512

Merged
merged 4 commits into from
Jan 26, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Dec 7, 2020

Description

Fix #231 : IngressEnricher now supports generating Ingress from XML configuration

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #512 (8099757) into master (03135ff) will increase coverage by 0.28%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #512      +/-   ##
============================================
+ Coverage     41.71%   41.99%   +0.28%     
- Complexity     2781     2828      +47     
============================================
  Files           397      401       +4     
  Lines         19369    19449      +80     
  Branches       2767     2778      +11     
============================================
+ Hits           8079     8168      +89     
+ Misses        10305    10290      -15     
- Partials        985      991       +6     
Impacted Files Coverage Δ Complexity Δ
...se/jkube/kit/config/resource/IngressTlsConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ipse/jkube/kit/config/resource/ResourceConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...kube/enricher/generic/openshift/RouteEnricher.java 78.57% <ø> (+0.44%) 31.00 <0.00> (-2.00) ⬆️
.../kit/enricher/api/util/KubernetesResourceUtil.java 37.66% <50.00%> (+0.27%) 52.00 <2.00> (+4.00)
...e/jkube/kit/config/resource/IngressRuleConfig.java 66.66% <66.66%> (ø) 4.00 <4.00> (?)
...config/resource/IngressRulePathResourceConfig.java 85.71% <85.71%> (ø) 5.00 <5.00> (?)
...ube/kit/config/resource/IngressRulePathConfig.java 88.88% <88.88%> (ø) 7.00 <7.00> (?)
...clipse/jkube/enricher/generic/IngressEnricher.java 87.14% <90.00%> (+28.71%) 39.00 <20.00> (+29.00)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03135ff...8099757. Read the comment docs.

Signed-off-by: Marc Nuri <marc@marcnuri.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa self-requested a review January 26, 2021 16:20
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

56.0% 56.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@manusa manusa merged commit 2e0f3ad into eclipse-jkube:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IngressEnricher ignores IngressRules defined in XML config
2 participants