Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShiftResourceMojoTest is failing on Windows due to use of \n as line separator #3180

Closed
1 task
rohanKanojia opened this issue Jun 19, 2024 · 4 comments · Fixed by #3183
Closed
1 task
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@rohanKanojia
Copy link
Member

Component

OpenShift Maven Plugin

Task description

Description

Related to #1338

⚠️ A windows machine is required to reproduce and fix problems in this issue

OpenShiftResourceMojoTest is failing on windows due to expecting a Linux line ending

This can easily be fixed by using platform independent %n and placing string inside String.format()

Expected Behavior

OpenShiftResourceMojoTest should pass on windows

Acceptance Criteria

  • OpenShiftResourceMojoTest should pass on windows
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 19, 2024
@rohanKanojia rohanKanojia changed the title OpenShiftResourceMojoTest is failing on Windows due to use of \n OpenShiftResourceMojoTest is failing on Windows due to use of \n as line separator Jun 19, 2024
@Thulasithang
Copy link
Contributor

Hey, I would like to take this up

@Thulasithang
Copy link
Contributor

@rohanKanojia the builder() method for the type BuildConfiguration returns an error even though lombok.Builder is imported in the BuildConfiguration.java file.

image

But this is not the case for all builder() methods. Since builder() methods in some files do work without errors.

For context, I am using vscode and I have the java extension pack so lombok works in my system.

@rohanKanojia
Copy link
Member Author

@Thulasithang : that's strange, I'm not VSCode user but could you please try clearing IDE cache to see if it resolves the issue?

@Thulasithang
Copy link
Contributor

Thulasithang commented Jun 21, 2024

that's strange, I'm not VSCode user but could you please try clearing IDE cache to see if it resolves the issue?

Clearing cache didn't work unfortunately. But I was able to reproduce the correct results on IntelliJ.

@manusa manusa added this to the 1.17.0 milestone Jun 25, 2024 — with automated-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants