-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the declaration of thrown runtime exceptions across codebase. #471
Labels
Comments
rohanKanojia
added
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
Nov 3, 2020
12 tasks
Declarations have been removed from method signatures, but still remain as JavaDoc entries:
|
manusa
added
good first issue
Good for newcomers
help wanted
Extra attention is needed
and removed
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
Jan 18, 2021
Please assign me this issue @rohanKanojia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
There are a few places in our codebase where we have
throws XYZException
in our methods, even ifXYZException
is aRuntimeException
. We should refactor these places to remove these throw occurrences. Consider this place:https://github.com/eclipse/jkube/blob/90439cb98fef038e8c991825d2a90ce414787fb6/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/access/ContainerHostConfig.java#L95-L98
This should actually look like this:
You can find out these places via a simple grep command:
For more information, you can check this sonar rule[0]
[0] https://sonarcloud.io/organizations/jkubeio/rules?open=java%3AS1130&rule_key=java%3AS1130
The text was updated successfully, but these errors were encountered: