Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Watch uses same logic as build to monitor changed assembly files #266

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jun 29, 2020

Description

Watch uses same logic as build to monitor changed assembly files (fixes #238 )

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #266 into master will increase coverage by 0.22%.
The diff coverage is 61.20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #266      +/-   ##
============================================
+ Coverage     30.67%   30.89%   +0.22%     
- Complexity     1923     1942      +19     
============================================
  Files           358      359       +1     
  Lines         18317    18300      -17     
  Branches       2751     2741      -10     
============================================
+ Hits           5618     5654      +36     
+ Misses        12040    11988      -52     
+ Partials        659      658       -1     
Impacted Files Coverage Δ Complexity Δ
...uild/core/assembly/AssemblyConfigurationUtils.java 96.15% <ø> (ø) 5.00 <0.00> (ø)
...jkube/kit/build/service/docker/ArchiveService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/jkube/kit/build/service/docker/WatchService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ube/kit/build/service/docker/config/WatchMode.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...se/jkube/springboot/watcher/SpringBootWatcher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...be/maven/plugin/mojo/build/AbstractDockerMojo.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...pse/jkube/maven/plugin/mojo/develop/WatchMojo.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...pse/jkube/maven/plugin/watcher/WatcherManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rg/eclipse/jkube/kit/common/AssemblyFileEntry.java 58.82% <58.82%> (ø) 5.00 <5.00> (?)
...e/jkube/kit/build/core/assembly/AssemblyFiles.java 66.66% <66.66%> (+50.53%) 3.00 <2.00> (+1.00)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad7145...ff71b87. Read the comment docs.

@manusa manusa marked this pull request as ready for review June 29, 2020 14:03
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

54.7% 54.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa merged commit 565739c into eclipse-jkube:master Jun 30, 2020
@manusa manusa deleted the fix/watch-assembly branch June 30, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WatchService doesn't consider changes FileSet assemblies
2 participants