Kushagra/issue#2970 #2988
Merged
Kushagra/issue#2970 #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoTimeUtilTest is refactored to not directly call Optional.get().
Update GoTimeUtilTest.java
…#2970 Revert "Update GoTimeUtilTest.java"
GoTimeUtilTest is refactored to not directly call Optional.get().
kushagrasinha123ks
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2988 (2024-04-30T07:03:15Z) ⚙️ JKube E2E Tests (8877416057)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2988 +/- ##
=============================================
+ Coverage 59.36% 70.72% +11.36%
- Complexity 4586 5071 +485
=============================================
Files 500 489 -11
Lines 21211 19572 -1639
Branches 2830 2526 -304
=============================================
+ Hits 12591 13842 +1251
+ Misses 7370 4501 -2869
+ Partials 1250 1229 -21 ☔ View full report in Codecov by Sentry. |
|
@manusa @sunix @rohanKanojia This commit is conflict free, please proceed with the review to merge it. |
| int result = GoTimeUtil.durationSeconds(duration).get(); | ||
| assertThat(result).isEqualTo(expectedDuration); | ||
| Optional<Integer> optionalResult = GoTimeUtil.durationSeconds(duration); | ||
| assertThat(optionalResult) |
There was a problem hiding this comment.
Could you please move the method call inline?
There was a problem hiding this comment.
Sure. You can move ahead with the review.
inlined the method calls in conversion function
| @@ -21,6 +21,7 @@ | |||
| import org.junit.jupiter.params.provider.ValueSource; | |||
|
|
|||
| import java.util.stream.Stream; | |||
| import java.util.Optional; | |||
There was a problem hiding this comment.
Is this import still used?
removed the unused imports.
|
rohanKanojia
approved these changes
Apr 29, 2024
|
@sunix please review the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored GoTimeUtilTest to avoid directly calling Optional.get(). Now, the test checks whether the Optional contains a value before fetching it.
Fixes #2970
Type of change
test, version modification, documentation, etc.)
Checklist
git config user.name "Kushagra Sinha"
git config user.email "kushagrasinha123ks@gmail.com"
git commit --amend --signoff
git push origin kushagra/issue#2970 -f