fix: replace AssertJ's deprecated asList() DSL method in IngressEnric… #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…herBehavioralTest Signed-off-by: heap-s <dqkushbro@gmail.com>
Eclipse JKube CI ReportStarted new GH workflow run for #3351 (2024-08-30T13:28:47Z) ⚙️ JKube E2E Tests (10633337207)
|
| @@ -53,7 +55,7 @@ void create_withNoServices_shouldNotCreateIngress() { | |||
| // When | |||
| new IngressEnricher(context).create(PlatformMode.kubernetes, klb); | |||
| // Then | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems).asList().isEmpty(); | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems).asInstanceOf(InstanceOfAssertFactories.LIST).isEmpty(); | |||
There was a problem hiding this comment.
Suggested change
| assertThat(klb.build()).extracting(KubernetesList::getItems).asInstanceOf(InstanceOfAssertFactories.LIST).isEmpty(); | |
| assertThat(klb.build()).extracting(KubernetesList::getItems).asInstanceOf(InstanceOfAssertFactories.list(HasMetadata.class)).isEmpty(); |
There was a problem hiding this comment.
Hey, I'm looking at this and I'm seeing that klb.build() IsInstanceOf Service.class. This was an oversight on my part, but is that preferred over HasMetadata.class or am I thinking of asInstanceOf() the wrong way?
There was a problem hiding this comment.
Pushing pushing a commit with asInstanceOf(InstanceOfAssertFactories.list(HasMetadata.class)) right now for each of these. If you could kindly still respond to my query above I'd appreciate it.
There was a problem hiding this comment.
In this case it doesn't really matter.
The answer would differ depending on what properties were to be extracted later on from the list (in an hypothetical test).
If you were to access spec (ServiceSpec), then you'd probably want Service. If you were to access metadata (ObjectMeta), then either option would be valid.
There was a problem hiding this comment.
Thanks for that answer @manusa I figured that, but because from what I've seen before when I was doing a similar issue it used Container.class. Thanks for making this clearer.
| @@ -64,7 +66,7 @@ void create_withServicesAndNoExternalUrls_shouldNotCreateIngress() { | |||
| // When | |||
| new IngressEnricher(context).create(PlatformMode.kubernetes, klb); | |||
| // Then | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems).asList().singleElement() | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems).asInstanceOf(InstanceOfAssertFactories.LIST).singleElement() | |||
There was a problem hiding this comment.
| @@ -112,7 +114,7 @@ void create_withServiceNotExposed_shouldNotCreateIngress() { | |||
| // When | |||
| new IngressEnricher(context).create(PlatformMode.kubernetes, klb); | |||
| // Then | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems).asList().singleElement() | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems).asInstanceOf(InstanceOfAssertFactories.LIST).singleElement() | |||
There was a problem hiding this comment.
| @@ -131,7 +133,7 @@ void create_withServices_shouldCreateNetworkingIngress() { | |||
| .hasFieldOrPropertyWithValue("metadata.name", "http") | |||
| .hasFieldOrPropertyWithValue("spec.defaultBackend.service.name", "http") | |||
| .hasFieldOrPropertyWithValue("spec.defaultBackend.service.port.number", 80) | |||
| .extracting("spec.rules").asList().isEmpty(); | |||
| .extracting("spec.rules").asInstanceOf(InstanceOfAssertFactories.LIST).isEmpty(); | |||
There was a problem hiding this comment.
| @@ -150,6 +152,6 @@ void create_withServicesAndTargetExtensions_shouldCreateExtensionsIngress() { | |||
| .hasFieldOrPropertyWithValue("metadata.name", "http") | |||
| .hasFieldOrPropertyWithValue("spec.backend.serviceName", "http") | |||
| .hasFieldOrPropertyWithValue("spec.backend.servicePort.value", 80) | |||
| .extracting("spec.rules").asList().isEmpty(); | |||
| .extracting("spec.rules").asInstanceOf(InstanceOfAssertFactories.LIST).isEmpty(); | |||
There was a problem hiding this comment.
…es.list(HasMetadata.class) Signed-off-by: heap-s <dqkushbro@gmail.com>
rohanKanojia
approved these changes
Aug 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…herBehavioralTest
Description
Fixes #3334
Type of change
test, version modification, documentation, etc.)
Checklist