Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: jkube-kit-config-image decoupled from Maven #45

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jan 13, 2020

#30 Second task: decouple jkube-kit-config-image from Maven

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #45 into master will increase coverage by 0.21%.
The diff coverage is 27.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
+ Coverage     24.39%   24.61%   +0.21%     
- Complexity     1329     1336       +7     
============================================
  Files           326      325       -1     
  Lines         17603    17572      -31     
  Branches       2691     2688       -3     
============================================
+ Hits           4294     4325      +31     
+ Misses        12811    12750      -61     
+ Partials        498      497       -1
Impacted Files Coverage Δ Complexity Δ
...pse/jkube/kit/build/maven/MavenArchiveService.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...jkube/kit/build/service/docker/ArchiveService.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...lipse/jkube/kit/build/maven/MavenBuildContext.java 34.72% <ø> (ø) 7 <0> (ø) ⬇️
.../eclipse/jkube/vertx/generator/VertxGenerator.java 50% <ø> (ø) 8 <0> (ø) ⬇️
...clipse/jkube/generator/webapp/WebAppGenerator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...config/handler/property/PropertyConfigHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...pse/jkube/kit/config/image/ImageConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/jkube/kit/build/service/docker/BuildService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../kit/config/image/build/AssemblyConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/eclipse/jkube/kit/common/util/MavenUtil.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c6d78...72e0555. Read the comment docs.

@manusa manusa mentioned this pull request Jan 13, 2020
7 tasks
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@rohanKanojia rohanKanojia merged commit 03040b8 into eclipse-jkube:master Jan 15, 2020
@manusa manusa deleted the refactor/decouple-maven branch January 15, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants