Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build environment of sonar jobs on CircleCI #562

Merged
merged 5 commits into from
Feb 1, 2021

Conversation

ohbus
Copy link
Contributor

@ohbus ohbus commented Feb 1, 2021

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@rohanKanojia
Copy link
Member

Seems like ThorntailV2HealthCheckEnricherTest is failing on JDK11. I've seen this failure myself while working with JDK11. Maybe we should refactor/remove it.

[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   ThorntailV2HealthCheckEnricherTest.setUp:67 » ClassCast class jdk.internal.loa...
[ERROR]   ThorntailV2HealthCheckEnricherTest.setUp:67 » IllegalArgument Value of type or...
[ERROR]   ThorntailV2HealthCheckEnricherTest.setUp:67 » IllegalArgument Value of type or...
[ERROR]   ThorntailV2HealthCheckEnricherTest.setUp:67 » IllegalArgument Value of type or...

@manusa
Copy link
Member

manusa commented Feb 1, 2021

I'll take a look

@rohanKanojia
Copy link
Member

ohk, Thanks a lot!

@ohbus
Copy link
Contributor Author

ohbus commented Feb 1, 2021

Seems like ThorntailV2HealthCheckEnricherTest is failing on JDK11. I've seen this failure myself while working with JDK11. Maybe we should refactor/remove it.

[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   ThorntailV2HealthCheckEnricherTest.setUp:67 » ClassCast class jdk.internal.loa...
[ERROR]   ThorntailV2HealthCheckEnricherTest.setUp:67 » IllegalArgument Value of type or...
[ERROR]   ThorntailV2HealthCheckEnricherTest.setUp:67 » IllegalArgument Value of type or...
[ERROR]   ThorntailV2HealthCheckEnricherTest.setUp:67 » IllegalArgument Value of type or...

I believe for the same reason I was not able to build the project on my local system, as I am also using JDK 11.

But the GitHub Actions jobs I suppose are all on JDK 11 right?

You may raise an issue regarding this and mention me, so that I can take a look at it to see if I can lend some helping hand.

Thanks.

@manusa manusa mentioned this pull request Feb 1, 2021
12 tasks
@manusa
Copy link
Member

manusa commented Feb 1, 2021

I believe for the same reason I was not able to build the project on my local system, as I am also using JDK 11.

But the GitHub Actions jobs I suppose are all on JDK 11 right?

You may raise an issue regarding this and mention me, so that I can take a look at it to see if I can lend some helping hand.

Thanks.

GitHub actions are on 11, but are only compiling the project (no unit tests are run).

These actions are used for e2e tests that are hosted in https://github.com/jkubeio/jkube-integration-tests/

I already created a PR with a fix #563. Once it's merged, you'll have to rebase your PR onto master and hopefully tests will be passing then and we'll be able to merge yours.

update circle ci to use JDK 11

Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #562 (42394a1) into master (659a0c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #562   +/-   ##
=========================================
  Coverage     42.04%   42.04%           
  Complexity     2840     2840           
=========================================
  Files           402      402           
  Lines         19461    19461           
  Branches       2777     2777           
=========================================
  Hits           8183     8183           
  Misses        10287    10287           
  Partials        991      991           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659a0c5...42394a1. Read the comment docs.

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for your contribution!

@manusa manusa merged commit efe7bcc into eclipse-jkube:master Feb 1, 2021
@ohbus ohbus deleted the jdk-11 branch February 2, 2021 06:21
@ohbus ohbus restored the jdk-11 branch February 2, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Sonar CircleCI job to Java 11
3 participants