-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade build environment of sonar jobs on CircleCI #562
Conversation
Seems like
|
I'll take a look |
ohk, Thanks a lot! |
I believe for the same reason I was not able to build the project on my local system, as I am also using JDK 11. But the GitHub Actions jobs I suppose are all on JDK 11 right? You may raise an issue regarding this and mention me, so that I can take a look at it to see if I can lend some helping hand. Thanks. |
GitHub actions are on 11, but are only compiling the project (no unit tests are run). These actions are used for e2e tests that are hosted in https://github.com/jkubeio/jkube-integration-tests/ I already created a PR with a fix #563. Once it's merged, you'll have to rebase your PR onto master and hopefully tests will be passing then and we'll be able to merge yours. |
update circle ci to use JDK 11 Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
=========================================
Coverage 42.04% 42.04%
Complexity 2840 2840
=========================================
Files 402 402
Lines 19461 19461
Branches 2777 2777
=========================================
Hits 8183 8183
Misses 10287 10287
Partials 991 991 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you very much for your contribution!
Description
docker
based environment frommachine
Type of change
test, version modification, documentation, etc.)
Checklist