Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment of NetworkPolicy to kubernetes-maven-plugin #620

Closed
wants to merge 1 commit into from

Conversation

marespane
Copy link
Contributor

@marespane marespane commented Mar 23, 2021

Description

I added NetworkPolicy so ti can be deployed with kuberentes-maven-plugin

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #620 (6f741fb) into master (120ee60) will decrease coverage by 0.02%.
The diff coverage is 5.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #620      +/-   ##
============================================
- Coverage     42.70%   42.67%   -0.03%     
  Complexity     2900     2900              
============================================
  Files           404      404              
  Lines         19500    19513      +13     
  Branches       2762     2763       +1     
============================================
+ Hits           8327     8328       +1     
- Misses        10181    10193      +12     
  Partials        992      992              
Impacted Files Coverage Δ Complexity Δ
.../jkube/kit/config/resource/ResourceVersioning.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eclipse/jkube/kit/config/service/ApplyService.java 19.04% <0.00%> (-0.05%) 51.00 <0.00> (ø)
.../kit/enricher/api/util/KubernetesResourceUtil.java 38.02% <33.33%> (-0.04%) 52.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120ee60...6f741fb. Read the comment docs.

@manusa manusa added this to the 1.2.0 milestone Mar 24, 2021
@rohanKanojia
Copy link
Member

@marespane : Thanks a lot for your PR 👍 . Could you please add some tests?

@manusa
Copy link
Member

manusa commented Mar 31, 2021

Hi @marespane
Your contribution looks very useful.
We can add the tests ourselves if you don't have time to, but we do need that you sign the ECA contribution agreement in order to be able to merge your commits:
image

@marespane
Copy link
Contributor Author

Hi @manusa,
sorry I didn't have time to finish those tests, I was planing to finish them this weekend. Regarding ECA I signed it, but it seems lime it's picking wrong email from commit that is changed by force push. I'll figure it out.

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2021

@manusa
Copy link
Member

manusa commented Mar 31, 2021

I'll try to implement tests now and see if we can push this into the 1.2 release.

@manusa
Copy link
Member

manusa commented Mar 31, 2021

Hi @marespane
Your commit was included as part of #642. Sorry for that, but your branch was protected and I couldn't add there the extra commits.
As a general recommendation, try to use branches different to main/master when creating pull requests, makes life easier for us.

@marespane
Copy link
Contributor Author

@manusa All it matters that it's merged. I'll do that next time. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants