Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add langium-config.json support #158

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Add langium-config.json support #158

merged 5 commits into from
Jul 20, 2021

Conversation

msujew
Copy link
Member

@msujew msujew commented Jul 2, 2021 •
edited
Loading

Closes #79

Also adds a few other things to the langium-cli package:

  • Console colors for errors, warnings, success messages, etc.
  • Catch any IO exceptions and log them appropriately.
  • Grammar validation is now executed before trying to run the CLI. (logging any errors)
  • JSON schema validation for config files.
  • A watch mode.

@msujew msujew force-pushed the msujew/langium-config branch 3 times, most recently from 4fd1fe3 to 92db41f Compare July 5, 2021 14:35
@msujew msujew added the cli CLI related issue label Jul 6, 2021
spoenemann
spoenemann reviewed Jul 9, 2021
View reviewed changes
packages/langium-cli/schema.json Show resolved Hide resolved
packages/langium-cli/src/generate.ts Outdated Show resolved Hide resolved
packages/langium-cli/src/langium.ts Outdated Show resolved Hide resolved
packages/langium/package.json Show resolved Hide resolved
packages/langium/src/documents/document-builder.ts Show resolved Hide resolved
@msujew msujew force-pushed the msujew/langium-config branch 2 times, most recently from 15ead81 to 42d0aaa Compare July 13, 2021 08:46
This was referenced Jul 13, 2021
Merged
Merged
spoenemann
spoenemann approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

packages/langium/src/documents/document-builder.ts Outdated Show resolved Hide resolved
@msujew msujew merged commit 79bf1dd into main Jul 20, 2021
@msujew msujew deleted the msujew/langium-config branch July 20, 2021 10:15
@spoenemann spoenemann added this to the v0.2.0 milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

@danieldietrich danieldietrich Awaiting requested review from danieldietrich

Assignees
No one assigned
Labels
cli CLI related issue
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Support configuration in external file
2 participants
@msujew @spoenemann