Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made all LSP services potentially asynchronous #269

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Made all LSP services potentially asynchronous #269

merged 2 commits into from
Oct 25, 2021

Conversation

spoenemann
Copy link
Contributor

@spoenemann spoenemann commented Oct 22, 2021 •
edited
Loading

This is an additional change for #238.

  • Added a Response type for LSP services that allows them to return a value or a promise.
  • Catch OperationCancelled and ResponseError thrown in LSP services.
  • Made the service APIs more consistent.
  • Added the DocumentHighlightKind to the document highlight service

@spoenemann spoenemann added this to the v0.2.0 milestone Oct 22, 2021
msujew
msujew approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the refactoring you did in the language-server.ts. I have a single nitpick.

packages/langium/src/lsp/code-action.ts Outdated Show resolved Hide resolved
@spoenemann spoenemann merged commit 4a1291e into main Oct 25, 2021
@spoenemann spoenemann deleted the issue238 branch October 25, 2021 07:11
@msujew msujew added the LSP Language Server Protocol integration label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhuebner dhuebner dhuebner left review comments

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
LSP Language Server Protocol integration
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@spoenemann @dhuebner @msujew