Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract string patterns for textmate grammar #289

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Nov 5, 2021

Closes #281

Extracts string patterns from the grammar to generate the textmate grammar. The issue only occurred because there was no string pattern in the textmate grammar in the first place, which would've prevented the keyword/comment pattern to be highlighted.

@msujew msujew added the cli CLI related issue label Nov 5, 2021
@msujew msujew added this to the v0.3.0 milestone Nov 5, 2021
@msujew msujew added the highlighting Related to syntax highlighting label Nov 6, 2021
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/langium-cli/src/generator/textmate-generator.ts Outdated Show resolved Hide resolved
@msujew msujew merged commit 8185094 into main Nov 9, 2021
@msujew msujew deleted the msujew/textmate-strings branch November 9, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli CLI related issue highlighting Related to syntax highlighting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two slashes inside a string detected as a comment
2 participants