Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client: cannot create an object instance without instance Id #75

Closed
msangoi opened this issue Feb 18, 2016 · 3 comments
Closed

Client: cannot create an object instance without instance Id #75

msangoi opened this issue Feb 18, 2016 · 3 comments
Assignees
@msangoi
Labels
bug Dysfunctionnal behavior

Comments

@msangoi
Copy link
Contributor

msangoi commented Feb 18, 2016

Following commit d16c6b3, a regression was introduced in the client side.
When an instance is created for a multi-instance object (e.g. Software Update, ACL), the TLV payload failed to be decoded because the instance Id is not provided.

I will provide a fix for this.
@msangoi msangoi added the bug Dysfunctionnal behavior label Feb 18, 2016
@msangoi msangoi self-assigned this Feb 18, 2016
@jvermillard
Copy link
Contributor

@msangoi
Copy link
Contributor Author

msangoi commented Feb 18, 2016

Actually, the instance ID is not anymore a parameter of the Create operation (spec change).
We need to change the Create Request API (impacting both server and client).

msangoi pushed a commit that referenced this issue Feb 23, 2016
Remove instanceId from the Create Request path (spec change)
c022353 
Fix create request decoding on the client side (issue #75)
@msangoi msangoi mentioned this issue Feb 23, 2016
Closed
msangoi pushed a commit that referenced this issue Feb 23, 2016
Remove instanceId from the Create Request path (spec change)
08b50e3 
And fix create request decoding on the client side (issue #75)
sbernard31 pushed a commit that referenced this issue Feb 25, 2016
@sbernard31
Remove instanceId from the Create Request path (spec change)
a4bf1b3 
And fix create request decoding on the client side (issue #75)
@sbernard31
Copy link
Contributor

Fixed in master (commit a4bf1b3)

@ptxmac ptxmac mentioned this issue Mar 16, 2016
Closed
mike-scott pushed a commit to mike-scott/leshan that referenced this issue Jan 31, 2018
@eugene-nikolaev
[fix eclipse-leshan#75] Server Treats NON-Message as CON-Message
6e8b97c 
Request#type is now Type.CON by default.

CoapClient: Move setting the request type to the convenience methods.
Client code can use the advanced() methods for sending a request that
it has configured manually whereas the convenience methods can be used
in the established way.

Uses Request#uri (if not blank) in the advanced() methods instead of
CoapClient#uri.

Conflicts:
	californium-core/src/main/java/org/eclipse/californium/core/CoapClient.java

Signed-off-by: Eugene Nikolaev <eug.nikolaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msangoi msangoi

Labels
bug Dysfunctionnal behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbernard31 @jvermillard @msangoi