Fix how we guess default version of core object. #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
force-pushed
the
default_version
branch
from
019baac
to
b92aef9
Compare
sbernard31
commented
Jun 13, 2023
There was a problem hiding this comment.
@JaroslawLegierski, I review my PR again.
I feel the client part is less clean but it should be enough for now.
Before to integrate this, I have some questions, see 👇
...er-redis/src/main/java/org/eclipse/leshan/server/redis/serialization/RegistrationSerDes.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/eclipse/leshan/server/registration/DefaultRegistrationDataExtractor.java
Show resolved
Hide resolved
sbernard31
force-pushed
the
default_version
branch
from
b92aef9
to
b620141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It aims to fix #1434.